* [PATCH] test: rev-parse-upstream: add missing cmp
@ 2023-05-09 0:02 Felipe Contreras
2023-05-10 3:56 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Felipe Contreras @ 2023-05-09 0:02 UTC (permalink / raw)
To: git; +Cc: Denton Liu, Felipe Contreras
It seems pretty clear 5236fce6b4 (t1507: stop losing return codes of git
commands, 2019-12-20) missed a test_cmp.
Cc: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
t/t1507-rev-parse-upstream.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/t1507-rev-parse-upstream.sh b/t/t1507-rev-parse-upstream.sh
index d94c72c672..cb9ef7e329 100755
--- a/t/t1507-rev-parse-upstream.sh
+++ b/t/t1507-rev-parse-upstream.sh
@@ -97,7 +97,8 @@ test_expect_success 'my-side@{u} resolves to correct commit' '
commit_subject my-side >actual &&
test_cmp expect actual &&
echo 5 >expect &&
- commit_subject my-side@{u} >actual
+ commit_subject my-side@{u} >actual &&
+ test_cmp expect actual
'
test_expect_success 'not-tracking@{u} fails' '
--
2.40.0+fc1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] test: rev-parse-upstream: add missing cmp
2023-05-09 0:02 [PATCH] test: rev-parse-upstream: add missing cmp Felipe Contreras
@ 2023-05-10 3:56 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2023-05-10 3:56 UTC (permalink / raw)
To: Felipe Contreras, Andrei Rybak; +Cc: git, Denton Liu
Felipe Contreras <felipe.contreras@gmail.com> writes:
> It seems pretty clear 5236fce6b4 (t1507: stop losing return codes of git
> commands, 2019-12-20) missed a test_cmp.
>
> Cc: Denton Liu <liu.denton@gmail.com>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
> t/t1507-rev-parse-upstream.sh | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/t/t1507-rev-parse-upstream.sh b/t/t1507-rev-parse-upstream.sh
> index d94c72c672..cb9ef7e329 100755
> --- a/t/t1507-rev-parse-upstream.sh
> +++ b/t/t1507-rev-parse-upstream.sh
> @@ -97,7 +97,8 @@ test_expect_success 'my-side@{u} resolves to correct commit' '
> commit_subject my-side >actual &&
> test_cmp expect actual &&
> echo 5 >expect &&
> - commit_subject my-side@{u} >actual
> + commit_subject my-side@{u} >actual &&
> + test_cmp expect actual
> '
>
> test_expect_success 'not-tracking@{u} fails' '
Good eyes.
a93cbe8d (t1507: assert output of rev-parse, 2023-03-18) and wanted
to do the same to this script, and the series that contains the
commit wanted to do the same to many other test scripts, but it
seems to have missed this one.
Will queue (on top of a93cbe8d, naturally).
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-10 4:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-09 0:02 [PATCH] test: rev-parse-upstream: add missing cmp Felipe Contreras
2023-05-10 3:56 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).