From: Junio C Hamano <gitster@pobox.com>
To: ashutosh.pandeyhlr007@gmail.com
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t2015-checkout-unborn.sh: changes the style for cd
Date: Tue, 21 Feb 2023 12:01:27 -0800 [thread overview]
Message-ID: <xmqqpma2eqjs.fsf@gitster.g> (raw)
In-Reply-To: <20230218192128.7963-1-ashutosh.pandeyhlr007@gmail.com> (ashutosh's message of "Sun, 19 Feb 2023 00:51:28 +0530")
ashutosh.pandeyhlr007@gmail.com writes:
> From: Ashutosh Pandey <ashutosh.pandeyhlr007@gmail.com>
>
> the `cd` followed the old style which wasn't consistent with the rest of
> the test suite, so this commit makes it consistent with the current
> style of the test suite for `cd` in subshell.
>
> Signed-off-by: Ashutosh Pandey <ashutosh.pandeyhlr007@gmail.com>
> ---
> this is my first time contributing to git I want to participate in
> this year's GSoC and I'm looking for some microprojects the ones
> that are listed on the website are mostly done so if anyone can
> suggest some beginners level microprojects that would be great.
>
> t/t2015-checkout-unborn.sh | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/t/t2015-checkout-unborn.sh b/t/t2015-checkout-unborn.sh
> index 9425aae639..fdc4149f15 100755
> --- a/t/t2015-checkout-unborn.sh
> +++ b/t/t2015-checkout-unborn.sh
> @@ -9,11 +9,12 @@ TEST_PASSES_SANITIZE_LEAK=true
>
> test_expect_success 'setup' '
> mkdir parent &&
> - (cd parent &&
> - git init &&
> - echo content >file &&
> - git add file &&
> - git commit -m base
> + (
> + cd parent &&
> + git init &&
> + echo content >file &&
> + git add file &&
> + git commit -m base
> ) &&
> git fetch parent main:origin
> '
OK. This makes it siimlar to the last test in the same t2015 script
that uses this "more recent" style.
Looks good.
Thanks.
next prev parent reply other threads:[~2023-02-21 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-18 19:21 [PATCH] t2015-checkout-unborn.sh: changes the style for cd ashutosh.pandeyhlr007
2023-02-21 20:01 ` Junio C Hamano [this message]
2023-02-21 20:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpma2eqjs.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ashutosh.pandeyhlr007@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).