From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>
Subject: [PATCH v2] ci: add address and undefined sanitizer tasks
Date: Mon, 10 Oct 2022 17:21:38 -0700 [thread overview]
Message-ID: <xmqqpmezxl9p.fsf@gitster.g> (raw)
In-Reply-To: <xmqq8rlo62ih.fsf@gitster.g> (Junio C. Hamano's message of "Sun, 09 Oct 2022 15:44:22 -0700")
The signal of "passed with asan, but not ubsan" (or vice versa) is
not that useful in practice, run both santizers in a single task.
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
Range-diff against v1:
1: 04a9dc5439 ! 1: cbf0d80ab1 ci: add address and undefined sanitizer tasks
@@ Metadata
## Commit message ##
ci: add address and undefined sanitizer tasks
+ The signal of "passed with asan, but not ubsan" (or vice versa) is
+ not that useful in practice, run both santizers in a single task.
+
+ Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
## .github/workflows/main.yml ##
@@ .github/workflows/main.yml: jobs:
- jobname: linux-leaks
cc: gcc
pool: ubuntu-latest
-+ - jobname: linux-address
-+ cc: gcc
-+ pool: ubuntu-latest
-+ - jobname: linux-undefined
++ - jobname: linux-sanitize
+ cc: gcc
+ pool: ubuntu-latest
env:
@@ ci/lib.sh: linux-leaks)
export GIT_TEST_PASSING_SANITIZE_LEAK=true
export GIT_TEST_SANITIZE_LEAK_LOG=true
;;
-+linux-address | linux-undefined)
-+ export SANITIZE=${jobname#linux-}
++linux-sanitize)
++ export SANITIZE=address,undefined
+ ;;
esac
.github/workflows/main.yml | 3 +++
ci/lib.sh | 3 +++
2 files changed, 6 insertions(+)
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 831f4df56c..92d27db0b9 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -251,6 +251,9 @@ jobs:
- jobname: linux-leaks
cc: gcc
pool: ubuntu-latest
+ - jobname: linux-sanitize
+ cc: gcc
+ pool: ubuntu-latest
env:
CC: ${{matrix.vector.cc}}
CC_PACKAGE: ${{matrix.vector.cc_package}}
diff --git a/ci/lib.sh b/ci/lib.sh
index 1b0cc2b57d..c9c4982e21 100755
--- a/ci/lib.sh
+++ b/ci/lib.sh
@@ -278,6 +278,9 @@ linux-leaks)
export GIT_TEST_PASSING_SANITIZE_LEAK=true
export GIT_TEST_SANITIZE_LEAK_LOG=true
;;
+linux-sanitize)
+ export SANITIZE=address,undefined
+ ;;
esac
MAKEFLAGS="$MAKEFLAGS CC=${CC:-cc}"
--
2.38.0-146-gaff07b31d7
next prev parent reply other threads:[~2022-10-11 0:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-09 22:44 [PATCH] ci: add address and undefined sanitizer tasks Junio C Hamano
2022-10-10 23:25 ` Junio C Hamano
2022-10-11 0:00 ` Jeff King
2022-10-11 0:09 ` Junio C Hamano
2022-10-21 5:59 ` Junio C Hamano
2022-10-21 6:25 ` Jeff King
2022-10-11 0:21 ` Junio C Hamano [this message]
2022-10-11 0:28 ` [PATCH v2] " Jeff King
2022-10-11 8:23 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpmezxl9p.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).