git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Shao-Ce SUN via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Shao-Ce SUN <sunshaoce@iscas.ac.cn>
Subject: Re: [PATCH] Fix wrong info in `INSTALL`
Date: Tue, 24 May 2022 15:21:07 -0700	[thread overview]
Message-ID: <xmqqpmk2efn0.fsf@gitster.g> (raw)
In-Reply-To: <pull.1241.git.1653424998869.gitgitgadget@gmail.com> (Shao-Ce SUN via GitGitGadget's message of "Tue, 24 May 2022 20:43:18 +0000")

"Shao-Ce SUN via GitGitGadget" <gitgitgadget@gmail.com> writes:

> -	$ make prefix=/usr all doc info ;# as yourself
> -	# make prefix=/usr install install-doc install-html install-info ;# as root
> +	$ make prefix=/usr all doc info ; $ as yourself

This and all the changes in the patch is wrong, but it is not
entirely your fault.  You need to know the shell syntax.

The semicolon in ";#" is an end of one command (i.e. "make"), and
the hash is "start of comment--ignore the rest of the line.

If you replace # with $, then "$ as yourself" would be fed to the
shell because $ is not a comment introducer.  The command line no
longer can be copied and pasted, starting from "make" to the end of
the line.

Thanks.


  parent reply	other threads:[~2022-05-24 22:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-24 20:43 [PATCH] Fix wrong info in `INSTALL` Shao-Ce SUN via GitGitGadget
2022-05-24 21:39 ` Ævar Arnfjörð Bjarmason
2022-05-24 22:03   ` Philippe Blain
2022-05-24 22:21 ` Junio C Hamano [this message]
2022-05-25  5:29 ` Christian Couder
2022-05-25 16:05   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpmk2efn0.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=sunshaoce@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).