From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id BA9F3C433F5
	for <git@archiver.kernel.org>; Tue, 24 May 2022 22:21:17 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S238569AbiEXWVQ (ORCPT <rfc822;git@archiver.kernel.org>);
        Tue, 24 May 2022 18:21:16 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32948 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S235732AbiEXWVN (ORCPT <rfc822;git@vger.kernel.org>);
        Tue, 24 May 2022 18:21:13 -0400
Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F16E525F1
        for <git@vger.kernel.org>; Tue, 24 May 2022 15:21:09 -0700 (PDT)
Received: from pb-smtp2.pobox.com (unknown [127.0.0.1])
        by pb-smtp2.pobox.com (Postfix) with ESMTP id 06D77127B58;
        Tue, 24 May 2022 18:21:09 -0400 (EDT)
        (envelope-from junio@pobox.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; s=sasl; bh=RDZiFJR+AJd6GHnZGDiASCG+UC7RJh8Mr1s5t8
        ztVxw=; b=UsufkGgJKJMVyosDA6BgD43s6D58gA2dvlRgvkn63+ZgchHsLnyHpb
        jjmgC3um6Lk17YVKfCV6zSaxvb/tk93k63SKr6EMkNh5HTdZPxXbsvppZ3SCnvaA
        kdiTNIyensJhVH6AkKT7xOUY+NVFWrzHbyuyTD5ilGZUZEGH0KQqI=
Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1])
        by pb-smtp2.pobox.com (Postfix) with ESMTP id F2887127B57;
        Tue, 24 May 2022 18:21:08 -0400 (EDT)
        (envelope-from junio@pobox.com)
Received: from pobox.com (unknown [34.83.92.57])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 5D60F127B56;
        Tue, 24 May 2022 18:21:08 -0400 (EDT)
        (envelope-from junio@pobox.com)
From:   Junio C Hamano <gitster@pobox.com>
To:     "Shao-Ce SUN via GitGitGadget" <gitgitgadget@gmail.com>
Cc:     git@vger.kernel.org, Shao-Ce SUN <sunshaoce@iscas.ac.cn>
Subject: Re: [PATCH] Fix wrong info in `INSTALL`
References: <pull.1241.git.1653424998869.gitgitgadget@gmail.com>
Date:   Tue, 24 May 2022 15:21:07 -0700
In-Reply-To: <pull.1241.git.1653424998869.gitgitgadget@gmail.com> (Shao-Ce SUN
        via GitGitGadget's message of "Tue, 24 May 2022 20:43:18 +0000")
Message-ID: <xmqqpmk2efn0.fsf@gitster.g>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: CF38877E-DBAF-11EC-9EBB-CB998F0A682E-77302942!pb-smtp2.pobox.com
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

"Shao-Ce SUN via GitGitGadget" <gitgitgadget@gmail.com> writes:

> -	$ make prefix=/usr all doc info ;# as yourself
> -	# make prefix=/usr install install-doc install-html install-info ;# as root
> +	$ make prefix=/usr all doc info ; $ as yourself

This and all the changes in the patch is wrong, but it is not
entirely your fault.  You need to know the shell syntax.

The semicolon in ";#" is an end of one command (i.e. "make"), and
the hash is "start of comment--ignore the rest of the line.

If you replace # with $, then "$ as yourself" would be fed to the
shell because $ is not a comment introducer.  The command line no
longer can be copied and pasted, starting from "make" to the end of
the line.

Thanks.