From: Junio C Hamano <gitster@pobox.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: "Jiang Xin" <worldhello.net@gmail.com>,
"Git List" <git@vger.kernel.org>,
"Fabian Stelzer" <fs@gigacodes.de>,
"ZheNing Hu" <adlternative@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Alexander Shopov" <ash@kambanaria.org>,
"Jordi Mas" <jmas@softcatala.org>,
"Matthias Rüster" <matthias.ruester@gmail.com>,
"Jimmy Angelakos" <vyruss@hellug.gr>,
"Christopher Díaz" <christopher.diaz.riv@gmail.com>,
"Jean-Noël Avila" <jn.avila@free.fr>,
"Alessandro Menti" <alessandro.menti@alessandromenti.it>,
"Gwan-gyeong Mun" <elongbug@gmail.com>, Arusekk <arek_koz@o2.pl>,
"Daniel Santos" <daniel@brilhante.top>,
"Dimitriy Ryazantcev" <DJm00n@mail.ru>,
"Peter Krefting" <peter@softwolves.pp.se>,
"Emir SARI" <bitigchi@me.com>,
"Trần Ngọc Quân" <vnwildman@gmail.com>,
"Fangyi Zhou" <me@fangyi.io>, "Yi-Jyun Pan" <pan93412@gmail.com>
Subject: Re: [PATCH v2] i18n: fix typos found during l10n for git 2.34.0
Date: Wed, 03 Nov 2021 09:26:30 -0700 [thread overview]
Message-ID: <xmqqpmrh8atl.fsf@gitster.g> (raw)
In-Reply-To: <7d9a893e-5dad-bd21-4ef7-6d47303abdc1@gmail.com> (Bagas Sanjaya's message of "Tue, 2 Nov 2021 17:17:22 +0700")
Bagas Sanjaya <bagasdotme@gmail.com> writes:
>> diff --git a/ref-filter.c b/ref-filter.c
>> index 282cdad103..08a3f839c9 100644
>> --- a/ref-filter.c
>> +++ b/ref-filter.c
>> @@ -1037,7 +1037,7 @@ int verify_ref_format(struct ref_format *format)
>> format->quote_style == QUOTE_TCL) &&
>> used_atom[at].atom_type == ATOM_RAW &&
>> used_atom[at].u.raw_data.option == RAW_BARE)
>> - die(_("--format=%.*s cannot be used with"
>> + die(_("--format=%.*s cannot be used with "
>> "--python, --shell, --tcl"), (int)(ep - sp - 2), sp + 2);
>> cp = ep + 1;
>>
>
> Why not using \n?
It is not quite clear to me why it should.
Among the possible string that is (ep - sp - 2) bytes long (i.e.
--python, --shell, --tcl, --raw), even with the longest, the
resulting message would become
fatal: --format=--python cannot be used with
--python, --shell, --tcl.
that is unusually short with such a newline in the middle.
next prev parent reply other threads:[~2021-11-03 16:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-30 2:09 [L10N] Kickoff for Git 2.34.0 round #1 Jiang Xin
2021-10-31 5:21 ` [PATCH] i18n: fix typos found during l10n for git 2.34.0 Jiang Xin
2021-11-01 2:14 ` [PATCH v2] " Jiang Xin
2021-11-01 5:51 ` Junio C Hamano
2021-11-02 10:17 ` Bagas Sanjaya
2021-11-03 16:26 ` Junio C Hamano [this message]
2021-11-04 1:27 ` Jiang Xin
2021-11-02 11:28 ` [PATCH] " ZheNing Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpmrh8atl.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=DJm00n@mail.ru \
--cc=adlternative@gmail.com \
--cc=alessandro.menti@alessandromenti.it \
--cc=arek_koz@o2.pl \
--cc=ash@kambanaria.org \
--cc=avarab@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=bitigchi@me.com \
--cc=christopher.diaz.riv@gmail.com \
--cc=daniel@brilhante.top \
--cc=elongbug@gmail.com \
--cc=fs@gigacodes.de \
--cc=git@vger.kernel.org \
--cc=jmas@softcatala.org \
--cc=jn.avila@free.fr \
--cc=matthias.ruester@gmail.com \
--cc=me@fangyi.io \
--cc=pan93412@gmail.com \
--cc=peter@softwolves.pp.se \
--cc=vnwildman@gmail.com \
--cc=vyruss@hellug.gr \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).