git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Dominyk Tiller <dominyktiller@gmail.com>,
	Git List <git@vger.kernel.org>,
	Dominyk Tiller via GitGitGadget <gitgitgadget@gmail.com>
Subject: Re: [PATCH] persistent-https: add go.mod to fix compile
Date: Tue, 30 Mar 2021 15:57:56 -0700	[thread overview]
Message-ID: <xmqqpmzgb66j.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cRmJLkkzsROuUifah2-RgSoEXmLnBDV8-a8iL3jF0CBLQ@mail.gmail.com> (Eric Sunshine's message of "Tue, 30 Mar 2021 18:12:54 -0400")

Eric Sunshine <sunshine@sunshineco.com> writes:

> On Tue, Mar 30, 2021 at 6:07 PM Junio C Hamano <gitster@pobox.com> wrote:
>> In any case, explaining these things in this response is good, but
>> eventually we need to make sure that the readers of the resulting
>> commit would not have to ask the same question, without having to
>> refer to external documentation.
>
> It might also be worthwhile -- for the non-Go readers -- for the
> commit message to mention that this addition of a `go.mod` file does
> not hinder those stuck with old pre-module versions of Go (it doesn't
> help them either, but that's less significant), thus this change does
> not require them to update to a modern version of Go (i.e. we're not
> raising the minimum required version).

Thanks for spelling out the most important part of what the readers
should be able to read from the resulting commit.  I agree that
piece of information is a must.




      reply	other threads:[~2021-03-30 22:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30 13:07 [PATCH] persistent-https: add go.mod to fix compile Dominyk Tiller via GitGitGadget
2021-03-30 19:09 ` Junio C Hamano
2021-03-30 21:30   ` Dominyk Tiller
2021-03-30 22:06     ` Junio C Hamano
2021-03-30 22:12       ` Eric Sunshine
2021-03-30 22:57         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpmzgb66j.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=dominyktiller@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).