From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH 2/2] style: do not "break" in switch() after "return"
Date: Tue, 15 Dec 2020 16:35:04 -0800 [thread overview]
Message-ID: <xmqqpn3a611j.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <xmqqtusm618e.fsf@gitster.c.googlers.com> (Junio C. Hamano's message of "Tue, 15 Dec 2020 16:30:57 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> Remove this unreachable code. It was found by SunCC, it's found by a
>> non-fatal warning emitted by SunCC. It's one of the things it's more
>> vehement about than GCC & Clang.
>
> This is a borderline Meh to me.
>
> I am even tempted to suggest that, unless all other case arms
> return, iow, if there is even a single arm that breaks, it may even
> be more future-proof to end any and all case arms that do not
> fall-thru to consistently end with break.
>
> If there is some way to fix the compiler, that may be preferrable,
> but as I said, this is borderline Meh and I do not care too deeply
> either way.
>
> Thanks.
Heh, this patch cleanly applies even to the tip of 'maint', which
means it is not a new issue at all. Is this caused by more recent
SunCC than you used in the past?
prev parent reply other threads:[~2020-12-16 0:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 20:00 [ANNOUNCE] Git v2.30.0-rc0 Junio C Hamano
2020-12-15 23:50 ` [PATCH 0/2] Make v2.30.0-rc0 compile on SunCC Ævar Arnfjörð Bjarmason
2020-12-15 23:50 ` [PATCH 1/2] strmap: do not "return" in a void function Ævar Arnfjörð Bjarmason
2020-12-16 0:24 ` Junio C Hamano
2020-12-15 23:50 ` [PATCH 2/2] style: do not "break" in switch() after "return" Ævar Arnfjörð Bjarmason
2020-12-16 0:30 ` Junio C Hamano
2020-12-16 0:35 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpn3a611j.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).