git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] reset.txt: update the title line to cover all use cases
Date: Sun, 21 Apr 2019 13:53:49 +0900	[thread overview]
Message-ID: <xmqqpnpgc61u.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190419093011.5753-1-pclouds@gmail.com> ("Nguyễn Thái Ngọc Duy"'s message of "Fri, 19 Apr 2019 16:30:11 +0700")

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> git-reset could be used in three different ways:
>
> - move HEAD to somewhere, optionally (not) update worktree/index
> - "move" HEAD to HEAD, mainly to update worktree/index
> - just update the index from some tree-ish
>
> The second case is frankly a (neat) corner case of the first one. But it
> makes it impossible for me to summarize git-reset in one line. Without
> it at least I could write "reset HEAD or the index".
>
> And even "reset all the things" is not correct because reseting worktree
> selectively is the job of git-checkout, not git-reset. Sigh.

I am not so sure if the current one is too bad.  The primary action
of the command is to reset the current HEAD to point at a specified
commit, and everything else it does is to make things consistent (in
other words, in line with having the HEAD at the given commit) with
respect to different requirements.  The "soft" reset wants to keep
the index and the working tree intact, the "merge" reset wants to
undo what a mergy operation would have done to the index and the
working tree if it started from a clean state, etc.  And "reset the
HEAD" is quite approiprate for a single line summary of what the
command does.  It perfectly is fine as long as the differences
brought in by having various "modes" are sufficiently described, I
would think.

> diff --git a/Documentation/git-reset.txt b/Documentation/git-reset.txt
> index 26e746c53f..e12d8edee6 100644
> --- a/Documentation/git-reset.txt
> +++ b/Documentation/git-reset.txt
> @@ -3,7 +3,7 @@ git-reset(1)
>  
>  NAME
>  ----
> -git-reset - Reset current HEAD to the specified state
> +git-reset - Reset "something"
>  
>  SYNOPSIS
>  --------

      reply	other threads:[~2019-04-21  4:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-19  9:30 [PATCH] reset.txt: update the title line to cover all use cases Nguyễn Thái Ngọc Duy
2019-04-21  4:53 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpnpgc61u.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).