Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: An idea for the "Leftover Bits": rebase -x to imply -i
Date: Wed, 16 Mar 2016 15:33:31 -0700	[thread overview]
Message-ID: <xmqqpouu2guc.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kZg3QkfjB1hwZKRS9Hqg-1H=kQwuwByX_rAMzveXtnp7Q@mail.gmail.com> (Stefan Beller's message of "Wed, 16 Mar 2016 14:12:39 -0700")

Stefan Beller <sbeller@google.com> writes:

> * "rebase -exec" requiries to be an explicit interactive rebase (i.e.
>   --interactive was given)
>   Could --exec just imply --interactive with a no-op editor?

Perhaps like this?  You have to defend the change with a good
description, have to protect the new behaviour with a new test from
future breakages, and may have to adjust existing tests if they are
expecting the current behaviour (I didn't test).

 git-rebase.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/git-rebase.sh b/git-rebase.sh
index cf60c43..c68baa0 100755
--- a/git-rebase.sh
+++ b/git-rebase.sh
@@ -248,6 +248,7 @@ do
 		;;
 	--exec=*)
 		cmd="${cmd}exec ${1#--exec=}${LF}"
+		interactive_rebase=explicit
 		;;
 	--interactive)
 		interactive_rebase=explicit

      parent reply	other threads:[~2016-03-16 22:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16 21:12 An idea for the "Leftover Bits": rebase -x to imply -i Stefan Beller
2016-03-16 22:19 ` Junio C Hamano
2016-03-16 22:51   ` Junio C Hamano
2016-03-16 23:18     ` Stefan Beller
2016-03-17  7:31       ` Junio C Hamano
2016-03-16 22:33 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpouu2guc.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox