Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: Mustafa Bayar via B4 Relay <devnull+mbayar.gitlab.com@kernel.org>,
	git@vger.kernel.org,  Patrick Steinhardt <ps@pks.im>,
	 Mustafa Bayar <mbayar@gitlab.com>
Subject: Re: [PATCH] ref-filter: fix double free when an object is missing
Date: Thu, 12 Nov 2026 12:29:48 -0800	[thread overview]
Message-ID: <xmqqqzgphjyb.fsf@gitster.g> (raw)
In-Reply-To: <CAOLa=ZQuT5+x-Rvxcv1CSYka3aGG2nV_hPFRDTYJEGgjbLhJwA@mail.gmail.com> (Karthik Nayak's message of "Thu, 12 Nov 2026 08:44:30 -0500")

Karthik Nayak <karthik.188@gmail.com> writes:

>> Similar to `maybe_object`, reset `content` at the start of get_object().
>> Add a regression test that exercises this path.
>
> I had only reviewed this patch internally and we did some iterations
> there [1], so mostly just rubber-stamping here that it looks good to me.
>
> Thanks for working on this!


I take the above with "only" -> "already".  Thanks for writing and
reviewing.

Will queue and mark the topic ready for 'next'.  The patch is very
well written, together with historical reference and all.

Thanks.


      reply	other threads:[~2026-11-12 20:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  9:48 [PATCH] ref-filter: fix double free when an object is missing Mustafa Bayar via B4 Relay
2026-11-12 13:44 ` Karthik Nayak
2026-11-12 20:29   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqqzgphjyb.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=devnull+mbayar.gitlab.com@kernel.org \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    --cc=mbayar@gitlab.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox