Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <ttaylorr@openai.com>
Cc: Toon Claes <toon@iotcl.com>,  Jeff King <peff@peff.net>,
	git@vger.kernel.org,  Gusted <gusted@codeberg.org>
Subject: Re: [PATCH 4/4] last-modified: keep per-path Bloom filters for wildcard pathspecs
Date: Wed, 05 Aug 2026 09:01:10 -0700	[thread overview]
Message-ID: <xmqqqzkcsgjd.fsf@gitster.g> (raw)
In-Reply-To: <anKHP7G1uE78e2x0@com-79390> (Taylor Blau's message of "Tue, 4 Aug 2026 17:43:43 -0700")

Taylor Blau <ttaylorr@openai.com> writes:

> On Tue, Aug 04, 2026 at 03:19:57PM -0700, Junio C Hamano wrote:
>> So what happened to this discussion?  Are we happy with the set of
>> patches in v1 after all, or are we still thinking it over?
>
> I don't have a strong sense of this particular discussion, since this
> sub-thread involves only Peff and Toon. But in general, I think that my
> comment[1] here needs to be resolved before we start merging this down.
>
> Thanks,
> Taylor
>
> [1]: https://lore.kernel.org/git/alq1Q55ezuN9ZI9j@com-79390/

Thanks.  Yes, the --show-trees issue looks a lot more relevant.


  reply	other threads:[~2026-08-05 16:01 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17 15:46 [PATCH 0/4] last-modified: use the pathspec's Bloom key to pre-filter commits Toon Claes
2026-07-17 15:46 ` [PATCH 1/4] revision: move bloom keyvec precondition into function Toon Claes
2026-07-18  7:57   ` Jeff King
2026-08-05 19:16     ` Toon Claes
2026-08-05 20:32       ` Jeff King
2026-07-17 15:47 ` [PATCH 2/4] revision: expose check for paths maybe changed in Bloom filter Toon Claes
2026-07-17 20:47   ` Junio C Hamano
2026-07-17 23:26     ` Taylor Blau
2026-07-17 15:47 ` [PATCH 3/4] last-modified: check pathspec against Bloom filter first Toon Claes
2026-07-17 23:05   ` Taylor Blau
2026-07-18  8:37     ` Jeff King
2026-07-18 21:22       ` Taylor Blau
2026-07-20  9:42         ` Jeff King
2026-07-17 15:47 ` [PATCH 4/4] last-modified: keep per-path Bloom filters for wildcard pathspecs Toon Claes
2026-07-17 19:16   ` Toon Claes
2026-07-18  8:14     ` Jeff King
2026-08-04 22:19       ` Junio C Hamano
2026-08-05  0:43         ` Taylor Blau
2026-08-05 16:01           ` Junio C Hamano [this message]
2026-08-05  1:18         ` Jeff King
2026-07-17 23:18   ` Taylor Blau
2026-07-17 19:13 ` [PATCH 0/4] last-modified: use the pathspec's Bloom key to pre-filter commits Toon Claes
2026-08-07 18:26 ` [PATCH v2 0/6] " Toon Claes
2026-08-07 18:26   ` [PATCH v2 1/6] revision: move bloom keyvec precondition into function Toon Claes
2026-08-07 18:26   ` [PATCH v2 2/6] revision: expose check for paths maybe changed in Bloom filter Toon Claes
2026-08-07 18:26   ` [PATCH v2 3/6] bloom: add helper to check if any key in a vector is present Toon Claes
2026-08-07 18:26   ` [PATCH v2 4/6] revision: add Bloom check that includes parent directories Toon Claes
2026-08-07 18:26   ` [PATCH v2 5/6] last-modified: check pathspec against Bloom filter first Toon Claes
2026-08-07 18:26   ` [PATCH v2 6/6] last-modified: keep per-path Bloom filters for wildcard pathspecs Toon Claes
2026-08-08 17:07     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqqzkcsgjd.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gusted@codeberg.org \
    --cc=peff@peff.net \
    --cc=toon@iotcl.com \
    --cc=ttaylorr@openai.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox