From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, oxsignal <awo@kakao.com>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH v2 05/12] t/unit-tests: introduce test helper to write reftable blocks
Date: Tue, 30 Jun 2026 10:25:44 -0700 [thread overview]
Message-ID: <xmqqqzlorld3.fsf@gitster.g> (raw)
In-Reply-To: <20260629-pks-reftable-hardening-v2-5-b0228e7d908d@pks.im> (Patrick Steinhardt's message of "Mon, 29 Jun 2026 11:02:18 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> Introduce a new test helper that allows us to write reftable blocks.
> This helper will be used by subsequent commits.
>
> Suggested-by: Christian Couder <christian.couder@gmail.com>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
> t/unit-tests/u-reftable-block.c | 47 ++++++++++++++++++++++++-----------------
> 1 file changed, 28 insertions(+), 19 deletions(-)
Nicely reduces boilerplate/setup code. Thanks, both.
next prev parent reply other threads:[~2026-06-30 17:25 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 8:23 [PATCH 00/11] reftable: harden against corrupted tables Patrick Steinhardt
2026-06-24 8:23 ` [PATCH 01/11] meson: support building fuzzers with libFuzzer Patrick Steinhardt
2026-06-24 8:23 ` [PATCH 02/11] oss-fuzz: add fuzzer for parsing reftables Patrick Steinhardt
2026-06-24 8:23 ` [PATCH 03/11] reftable/basics: fix OOB read on binary search of empty range Patrick Steinhardt
2026-06-24 8:23 ` [PATCH 04/11] reftable/record: don't abort when decoding invalid ref value type Patrick Steinhardt
2026-06-24 8:23 ` [PATCH 05/11] reftable/block: fix OOB write with bogus inflated log size Patrick Steinhardt
2026-06-26 7:48 ` Christian Couder
2026-06-29 7:08 ` Patrick Steinhardt
2026-06-24 8:23 ` [PATCH 06/11] reftable/block: fix OOB read with bogus block size Patrick Steinhardt
2026-06-24 8:23 ` [PATCH 07/11] reftable/block: fix OOB read with bogus restart count Patrick Steinhardt
2026-06-24 8:23 ` [PATCH 08/11] reftable/block: fix use of uninitialized memory when binsearch fails Patrick Steinhardt
2026-06-24 8:23 ` [PATCH 09/11] reftable/block: fix OOB read with bogus restart offset Patrick Steinhardt
2026-06-24 8:23 ` [PATCH 10/11] reftable/table: fix NULL pointer access when seeking to bogus offsets Patrick Steinhardt
2026-06-24 8:23 ` [PATCH 11/11] reftable/table: fix OOB read on truncated table Patrick Steinhardt
2026-06-29 9:02 ` [PATCH v2 00/12] reftable: harden against corrupted tables Patrick Steinhardt
2026-06-29 9:02 ` [PATCH v2 01/12] meson: support building fuzzers with libFuzzer Patrick Steinhardt
2026-06-29 9:02 ` [PATCH v2 02/12] oss-fuzz: add fuzzer for parsing reftables Patrick Steinhardt
2026-06-29 9:02 ` [PATCH v2 03/12] reftable/basics: fix OOB read on binary search of empty range Patrick Steinhardt
2026-06-29 9:02 ` [PATCH v2 04/12] reftable/record: don't abort when decoding invalid ref value type Patrick Steinhardt
2026-06-29 9:02 ` [PATCH v2 05/12] t/unit-tests: introduce test helper to write reftable blocks Patrick Steinhardt
2026-06-30 17:25 ` Junio C Hamano [this message]
2026-07-02 9:31 ` Christian Couder
2026-07-03 2:52 ` Junio C Hamano
2026-06-29 9:02 ` [PATCH v2 06/12] reftable/block: fix OOB write with bogus inflated log size Patrick Steinhardt
2026-07-03 9:23 ` Toon Claes
2026-07-03 10:32 ` Patrick Steinhardt
2026-06-29 9:02 ` [PATCH v2 07/12] reftable/block: fix OOB read with bogus block size Patrick Steinhardt
2026-07-03 9:28 ` Toon Claes
2026-07-03 10:32 ` Patrick Steinhardt
2026-06-29 9:02 ` [PATCH v2 08/12] reftable/block: fix OOB read with bogus restart count Patrick Steinhardt
2026-06-29 9:02 ` [PATCH v2 09/12] reftable/block: fix use of uninitialized memory when binsearch fails Patrick Steinhardt
2026-06-29 9:02 ` [PATCH v2 10/12] reftable/block: fix OOB read with bogus restart offset Patrick Steinhardt
2026-06-29 9:02 ` [PATCH v2 11/12] reftable/table: fix NULL pointer access when seeking to bogus offsets Patrick Steinhardt
2026-06-29 9:02 ` [PATCH v2 12/12] reftable/table: fix OOB read on truncated table Patrick Steinhardt
2026-07-03 12:58 ` [PATCH v3 00/12] reftable: harden against corrupted tables Patrick Steinhardt
2026-07-03 12:58 ` [PATCH v3 01/12] meson: support building fuzzers with libFuzzer Patrick Steinhardt
2026-07-03 12:58 ` [PATCH v3 02/12] oss-fuzz: add fuzzer for parsing reftables Patrick Steinhardt
2026-07-03 12:58 ` [PATCH v3 03/12] reftable/basics: fix OOB read on binary search of empty range Patrick Steinhardt
2026-07-03 12:58 ` [PATCH v3 04/12] reftable/record: don't abort when decoding invalid ref value type Patrick Steinhardt
2026-07-03 12:58 ` [PATCH v3 05/12] t/unit-tests: introduce test helper to write reftable blocks Patrick Steinhardt
2026-07-03 12:58 ` [PATCH v3 06/12] reftable/block: fix OOB write with bogus inflated log size Patrick Steinhardt
2026-07-03 12:58 ` [PATCH v3 07/12] reftable/block: fix OOB read with bogus block size Patrick Steinhardt
2026-07-03 12:58 ` [PATCH v3 08/12] reftable/block: fix OOB read with bogus restart count Patrick Steinhardt
2026-07-03 12:58 ` [PATCH v3 09/12] reftable/block: fix use of uninitialized memory when binsearch fails Patrick Steinhardt
2026-07-03 12:58 ` [PATCH v3 10/12] reftable/block: fix OOB read with bogus restart offset Patrick Steinhardt
2026-07-03 12:58 ` [PATCH v3 11/12] reftable/table: fix NULL pointer access when seeking to bogus offsets Patrick Steinhardt
2026-07-03 12:58 ` [PATCH v3 12/12] reftable/table: fix OOB read on truncated table Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqqzlorld3.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=awo@kakao.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox