public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Burak Kaan Karaçay" <bkkaracay@gmail.com>
Cc: git@vger.kernel.org,  christian.couder@gmail.com
Subject: Re: [GSOC PATCH] t2003: modernize test path helpers
Date: Mon, 09 Feb 2026 00:35:51 -0800	[thread overview]
Message-ID: <xmqqqzqu71qw.fsf@gitster.g> (raw)
In-Reply-To: <20260208202809.270523-1-bkkaracay@gmail.com> ("Burak Kaan Karaçay"'s message of "Sun, 8 Feb 2026 23:28:09 +0300")

Burak Kaan Karaçay <bkkaracay@gmail.com> writes:

> Subject: Re: [GSOC PATCH] t2003: modernize test path helpers

What we see in the patch are more uses of test path helpers, and
nothing in these path helpers are changed at all.

    Subject: t2003: modernize path existence checks using test helpers

or something like that, perhaps.

> -	test ! -h path1 && test -d path1 &&
> -	test -f path1/file1 && test ! -f path2/file1
> +	test_path_is_dir_not_symlink path1 &&
> +	test_path_is_file path1/file1 && test_path_is_missing path2/file1

The above is a faithful rewrite, but as a separate patch to
follow-up this file, the last line should be split into two, having
one command on each line.

All changes in this patch looked good.  Will queue.

Thanks.

      reply	other threads:[~2026-02-09  8:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-08 20:28 [GSOC PATCH] t2003: modernize test path helpers Burak Kaan Karaçay
2026-02-09  8:35 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqqzqu71qw.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=bkkaracay@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox