From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] ci(*-leaks): skip the git-svn tests to save time
Date: Fri, 23 Jan 2026 09:46:02 -0800 [thread overview]
Message-ID: <xmqqqzrggr39.fsf@gitster.g> (raw)
In-Reply-To: <a29ce07a-9585-475e-bb3d-4742f2ec400a@gmail.com> (Phillip Wood's message of "Fri, 23 Jan 2026 14:47:11 +0000")
Phillip Wood <phillip.wood123@gmail.com> writes:
> ... If "git svn" was
> implemented in C then we probably would want to check it for leaks even
> though it called a foreign program. That's a long winded way of saying I
> don't have any better suggestions!
I am not sure if I agree. If Perl interpreter used to run the Perl
version of "git svn" were found leaky, are we willing to go in and
plug leaks there? Not likely, particularly since it is not what we
ship and we do not have control over which version of Perl the users
have on their systems. So we say "Perl is foreign and we are not
equipped to plug leaks in various versions of it on users' systems,
so it is not worth spending cycles to test for leaks in it".
If "git svn" were in C, linked with libsvn without using the perl
binding, and libsvn were found leaky, the story is the same. We do
not control the version of libsvn the users have on their systems,
we are not equipped to plug leaks in there, so it is not our job to
spend cycles to test for leaks in it.
next prev parent reply other threads:[~2026-01-23 17:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 17:31 [PATCH] ci(*-leaks): skip the git-svn tests to save time Johannes Schindelin via GitGitGadget
2026-01-16 19:20 ` Junio C Hamano
2026-01-17 15:04 ` Phillip Wood
2026-01-17 18:34 ` Junio C Hamano
2026-01-17 19:02 ` Kristoffer Haugsbakk
2026-01-18 0:35 ` Junio C Hamano
2026-01-20 10:31 ` Phillip Wood
2026-01-20 10:34 ` Phillip Wood
2026-01-20 15:42 ` Junio C Hamano
2026-01-23 14:47 ` Phillip Wood
2026-01-23 17:46 ` Junio C Hamano [this message]
2026-01-26 9:47 ` Phillip Wood
2026-01-26 16:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqqzrggr39.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox