From: Junio C Hamano <gitster@pobox.com>
To: "D. Ben Knoble" <ben.knoble+github@gmail.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH v2] perl: also mark git-contacts executable
Date: Tue, 11 Nov 2025 10:59:01 -0800 [thread overview]
Message-ID: <xmqqqzu4wg3u.fsf@gitster.g> (raw)
In-Reply-To: <15f07afcb66a900e5391e6b07e0701ce84236f04.1762820188.git.ben.knoble+github@gmail.com> (D. Ben Knoble's message of "Mon, 10 Nov 2025 19:19:57 -0500")
"D. Ben Knoble" <ben.knoble+github@gmail.com> writes:
> When installing git-contacts with Meson via -Dcontrib=contacts, the
> default Perl generation fails to mark it executable. As a result, "git
> contacts" reports "'contacts' is not a git command."
>
> Unlike generate-script.sh, we aren't testing the basename here; so, glob
> the script name in the case arm to match wherever the input comes from.
>
> Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>
> ---
>
> A small typo fix for the commit message, thanks to Patrick.
>
> v1: https://lore.kernel.org/git/7fbb341e8f05fcde3a1543e3bb4e5a3ec1101692.1762280097.git.ben.knoble+github@gmail.com/
Together with the html one, these patches match what I have already
queued with local tweaks, so I won't replace them (they are in
'next' now).
Thanks.
next prev parent reply other threads:[~2025-11-11 18:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 18:14 [PATCH] perl: also mark git-contacts executable D. Ben Knoble
2025-11-06 7:22 ` Patrick Steinhardt
2025-11-06 14:07 ` Ben Knoble
2025-11-06 15:28 ` Junio C Hamano
2025-11-11 0:19 ` [PATCH v2] " D. Ben Knoble
2025-11-11 18:59 ` Junio C Hamano [this message]
2025-11-11 19:00 ` D. Ben Knoble
2025-11-11 20:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqqzu4wg3u.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble+github@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).