git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH 0/3] ci: don't compile whole project when testing docs with Meson
Date: Tue, 16 Sep 2025 09:24:41 -0700	[thread overview]
Message-ID: <xmqqqzw6nz5i.fsf@gitster.g> (raw)
In-Reply-To: <aMkGluKUBfq6VNOQ@pks.im> (Patrick Steinhardt's message of "Tue, 16 Sep 2025 08:41:26 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> I meant the Meson option `-Ddocs=man,html`. I feel it's more natural
> there if the accompanying target is also called "docs" there.

Ahh.  OK, so if I said "meson -Ddocs=" to choose neither format,
that would essentially be the same as "do build the binaries but not
the docs"?

I guess that is from the very beginning 904339ed (Introduce support
for the Meson build system, 2024-12-06) that get_option('docs') is
part of the build system, so it *is* way too late to fix it now.

> Another option is that we could also just have both. In that case users
> of the Makefile could continue to use the "doc" target with Meson, as
> they are used to. And users that are used to Meson can use the "docs"
> target.

Meaning you'd allow one to be an alias for the other?  I am not sure
if it is worth it for something small like this.  Let's leave things
as they are.

Thanks.

  reply	other threads:[~2025-09-16 16:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-11  9:16 [PATCH 0/3] ci: don't compile whole project when testing docs with Meson Patrick Steinhardt
2025-09-11  9:16 ` [PATCH 1/3] meson: introduce a "docs" alias to compile documentation only Patrick Steinhardt
2025-09-16  9:14   ` Karthik Nayak
2025-09-16  9:55     ` Patrick Steinhardt
2025-09-16 11:50       ` Karthik Nayak
2025-09-11  9:16 ` [PATCH 2/3] meson: print docs backend as part of the summary Patrick Steinhardt
2025-09-11  9:16 ` [PATCH 3/3] ci: don't compile whole project when testing docs with Meson Patrick Steinhardt
2025-09-16  9:16   ` Karthik Nayak
2025-09-11 17:02 ` [PATCH 0/3] " Junio C Hamano
2025-09-15  6:04   ` Patrick Steinhardt
2025-09-15 23:13     ` Junio C Hamano
2025-09-16  6:41       ` Patrick Steinhardt
2025-09-16 16:24         ` Junio C Hamano [this message]
2025-09-16  9:17 ` Karthik Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqqzw6nz5i.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).