public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Todd Zullinger <tmz@pobox.com>
Cc: git@vger.kernel.org,  Justin Tobler <jltobler@gmail.com>
Subject: Re: [PATCH] t: avoid git config syntax from newer releases
Date: Tue, 08 Jul 2025 15:08:30 -0700	[thread overview]
Message-ID: <xmqqqzyqs5cx.fsf@gitster.g> (raw)
In-Reply-To: <20250708210529.1214574-1-tmz@pobox.com> (Todd Zullinger's message of "Tue, 8 Jul 2025 17:05:27 -0400")

Todd Zullinger <tmz@pobox.com> writes:

> In a recent security release, 05e9cd64ee (config: quote values
> containing CR character, 2025-05-19) added calls to `git config get`,
> `git config set`, and `git config unset` which are not present on the
> maint-2.43 branch.
>
> These subcommands were added in the following commits, released in
> git-2.46.0:
>
>   4e51389000 (builtin/config: introduce "get" subcommand, 2024-05-06),
>   00bbdde141 (builtin/config: introduce "set" subcommand, 2024-05-06),
>   95ea69c67b (builtin/config: introduce "unset" subcommand, 2024-05-06)
>
> Revert to the previous `git config` syntax for older maintenance
> branches.
>
> Signed-off-by: Todd Zullinger <tmz@pobox.com>
> ---
> ...
> This is based on maint-2.43.  I tested that it merges cleanly to 2.44 and 2.45.
> I have only run a build with 2.45.4 so far.

Thanks, will queue.


  reply	other threads:[~2025-07-08 22:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-08 17:01 [ANNOUNCE] Git v2.50.1 and friends Junio C Hamano
2025-07-08 20:28 ` Todd Zullinger
2025-07-08 21:05   ` [PATCH] t: avoid git config syntax from newer releases Todd Zullinger
2025-07-08 22:08     ` Junio C Hamano [this message]
2025-07-09 14:30     ` Justin Tobler
2025-07-09 16:08       ` Todd Zullinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqqzyqs5cx.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jltobler@gmail.com \
    --cc=tmz@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox