git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Per Cederqvist <ceder@lysator.liu.se>,  git@vger.kernel.org
Subject: Re: [PATCH] remote: detect collisions in remote names
Date: Mon, 07 Jul 2025 06:59:00 -0700	[thread overview]
Message-ID: <xmqqqzys5cgr.fsf@gitster.g> (raw)
In-Reply-To: <20250705185842.GA2496172@coredump.intra.peff.net> (Jeff King's message of "Sat, 5 Jul 2025 14:58:42 -0400")

Jeff King <peff@peff.net> writes:

> On Sat, Jul 05, 2025 at 12:57:50PM -0400, Jeff King wrote:
>
>> So I dunno. It feels like a configuration error in most cases, but not
>> all. I'd probably say that people touching the config manually should be
>> allowed to do what they want, but maybe "git remote" should be a bit
>> more careful about names being proper subsets of existing remotes (it
>> should already prevent the exact-match above, I'd think, because the ref
>> namespace it uses will always match the configuration name).
>
> So I'm not entirely convinced we should do anything here. The answer
> might just be "if it hurts, don't do it". But if we wanted any
> protections in the "git remote" porcelain, they might look like this:

I have firmly been in the "if it hurts..." camp.  People can do
weird things that may not make much sense to me, but do make sense
in their workflow that may be vastly different from mine.

But I do not think of any downsides from forbidding outer and
outer/inner existing at the same time, either ;-).

Thanks.

  parent reply	other threads:[~2025-07-07 13:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-03 19:33 Allowing "/" in the name of a git remote is a strange choice Per Cederqvist
2025-07-04  4:51 ` Junio C Hamano
2025-07-04  5:13   ` Patrick Steinhardt
2025-07-04  8:10     ` Lidong Yan
2025-07-04  8:17     ` Lidong Yan
2025-07-04 14:18     ` Junio C Hamano
2025-07-04  6:42   ` Per Cederqvist
2025-07-05 16:57 ` Jeff King
2025-07-05 18:58   ` [PATCH] remote: detect collisions in remote names Jeff King
2025-07-07  9:14     ` Patrick Steinhardt
2025-07-07 20:28       ` Jeff King
2025-07-07 21:04         ` Junio C Hamano
2025-07-08 22:59           ` Jeff King
2025-07-08 23:02             ` Jeff King
2025-07-08 23:28             ` Junio C Hamano
2025-07-09  1:21               ` Jeff King
2025-07-07 13:59     ` Junio C Hamano [this message]
2025-07-09 11:56     ` Raymond E. Pasco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqqzys5cgr.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ceder@lysator.liu.se \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).