From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b7-smtp.messagingengine.com (fout-b7-smtp.messagingengine.com [202.12.124.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46FD321E097 for ; Mon, 9 Jun 2025 20:19:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.150 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749500386; cv=none; b=p+P8tjkMI0vGRlxFfaE/Qx/m2Sk3oI5jDgob8+TQ/HADMOr8expi6mq7UMY4sLszrWF0RKFx1vNo46D+oNfTd4Uj/0Ioyq4GssPNrMM//9/UXBPFzbkARLLqcF18PpFFmcJCNy8Sp+boKX8Vdfd5kAZR+2gmq7ki/4/n1pFRER0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749500386; c=relaxed/simple; bh=GfPJhDYfJ/Cu0lf7c5xr5olIL+eiFJRL+mnpLKx55IU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=l6Ksaz+zAtWn7SfyfCXcMNp3kPYVdUHWh5zCxnnypIQTVHO+Wx8xOyYaNC0pOoT/94UbYBXHa+G3cZUJw8DwYjGd22faROq2tHCNqqJOCvZwF4vzY3qNr81wgZ3iBR71AIDT78hECBwviju4c++8ubgJzpf08M3lk8MfVxPxFIQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b=HAo5dxYL; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=UyQOG6LF; arc=none smtp.client-ip=202.12.124.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b="HAo5dxYL"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="UyQOG6LF" Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id 4CA851140338; Mon, 9 Jun 2025 16:19:43 -0400 (EDT) Received: from phl-frontend-01 ([10.202.2.160]) by phl-compute-05.internal (MEProxy); Mon, 09 Jun 2025 16:19:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1749500383; x=1749586783; bh=GfPJhDYfJ/ Cu0lf7c5xr5olIL+eiFJRL+mnpLKx55IU=; b=HAo5dxYLUJ832Fsb95MBNzD9eg d67uRbaOS0mIs3ErpYrC1rNkQBvdDhvgSXz8JM92RSxA5mnatHPDKhRUihBhf17W UfNuTl0ijnv6Vm08EyzA4P8jWlQvg9DI+//36T2cjxWGr7nrLYBnmBH4DTpDMg0n UeuT5DGZf8gBucUsX82qxoohLiYhOZjxzSi4mOmsnByDgg+YAvyUMXqgpOssOLjj qZImAgRtPBK/aZp4xIHQwAPwL3BxcLuZ6f2FpP6bJWDhmaqIlnzCGEexgBDzBjDL HbpKrqQX/7+lxZT/9OfrP1SDBmtjsl4HHrCT5yYs19VAD79qpW1LR1PspekA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1749500383; x=1749586783; bh=GfPJhDYfJ/Cu0lf7c5xr5olIL+eiFJRL+mn pLKx55IU=; b=UyQOG6LFXiAo09W2M7qMr46Tl0r3NsKdFEp8+K1iCk43oObgcZv 1u2SbTOThFH7+jt5wqYD08nuTFmHcV9bZ9heb4tStgLFkwJRdp/9u+thmqj4XLsy IB2wFGlIeeypwG+rAQSrjHt5hddCWGKjLZX7JojashSYTSjKx8ov0J+WyFhMUdNN 2VKetFs3XKRWn6Guov4w/u+L3XnG02NmTiAWY+I9t+MXBv80fKZlgD8+pZ6pY4DC vhCPnZzfmsHYKbERyLZOO0+UZmI1vHEZWnVvmqFANBCArHqo3CXD8q2t9IiObLP0 k90EwJPIPtpouxZRnvfwc/VwUOiFPDinT7w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdeljeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkfgggtgesthdtredttdertden ucfhrhhomheplfhunhhiohcuvecujfgrmhgrnhhouceoghhithhsthgvrhesphhosghogi drtghomheqnecuggftrfgrthhtvghrnhepfeevteetjeehueegffelvdetieevffeufeej leeuffetiefggfeftdfhfeeigeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepghhithhsthgvrhesphhosghogidrtghomhdpnhgspghrtghp thhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohephhhilhgtohdrfihijh gsvghnghgrsehgmhgrihhlrdgtohhmpdhrtghpthhtohepmhhirhhthhdrhhhitghkfhho rhgusehgmhgrihhlrdgtohhmpdhrtghpthhtohepghhithesvhhgvghrrdhkvghrnhgvlh drohhrghdprhgtphhtthhopehgihhtshhtvghrsehpohgsohigrdgtohhm X-ME-Proxy: Feedback-ID: if26b431b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 9 Jun 2025 16:19:42 -0400 (EDT) From: Junio C Hamano To: Hilco Wijbenga Cc: M Hickford , Git Mailing List Subject: Re: Suggestion: error "tag ... already exists" should distinguish between tagging different or same commit: In-Reply-To: (Hilco Wijbenga's message of "Mon, 9 Jun 2025 12:37:41 -0700") References: Date: Mon, 09 Jun 2025 13:19:41 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Hilco Wijbenga writes: > Does it really make sense for that first example to fail, though? "git > tag hello v1.9.5" is an idempotent operation, isn't it? The second > attempt is a no-op? > > If "git tag ..." simply does nothing if the tag already exists (as > requested) then that would make the OP's issue go away: only the 2nd > example would fail. I do not think I personally mind that direction; when I responded, I thought that in the example, 'hello' is initially pointing at something entirely different (perhaps v2.0.0), though. But it may be tricky to do, though. It is easy for lightweight tags, but you'd have to fail an attempt to add an annotated and/or signed tag without -f anyway, so you have to be prepared to answer "why does this behave differently with and without -a/-s?".