git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Patrick Steinhardt <ps@pks.im>,  git@vger.kernel.org
Subject: Re: [PATCH] ci: skip unavailable external software
Date: Fri, 25 Apr 2025 07:41:49 -0700	[thread overview]
Message-ID: <xmqqr01guwuq.fsf@gitster.g> (raw)
In-Reply-To: <a80a320b-80ca-3d61-a4a2-f2528e7ca053@gmx.de> (Johannes Schindelin's message of "Fri, 25 Apr 2025 14:01:20 +0200 (CEST)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> That is true. It would probably also make sense to mark the message as a
> `::warning::` on GitHub (and the equivalent on GitLab), so that it is
> shown a bit more prominently in the CI summary.

::warning:: may be a good idea, but I actually think we should
remove the message when we say "ah wget && chmod failed, so let's
remove".  At the end of the same script, there already is "ah jgit
is not there, so let's warn" code exists (and it would falsely say
"jgit file exists but cannot be executed" and take the whole thing
down if we do not remove after a failed download).  The ::warning::
should belong there.

Thanks.

  reply	other threads:[~2025-04-25 14:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-24 22:13 repo.eclipse.org outage breaking all our linux CI jobs Junio C Hamano
2025-04-24 23:10 ` [PATCH] ci: skip unavailable external software Junio C Hamano
2025-04-25  4:19   ` Patrick Steinhardt
2025-04-25  9:49     ` Junio C Hamano
2025-04-25 10:02       ` Patrick Steinhardt
2025-04-25 14:39         ` Junio C Hamano
2025-04-25 12:01     ` Johannes Schindelin
2025-04-25 14:41       ` Junio C Hamano [this message]
2025-04-25 15:38         ` [PATCH 0/2] ci: update unavailable external software handling Junio C Hamano
2025-04-25 15:38           ` [PATCH 1/2] ci: update the message for unavailble third-party software Junio C Hamano
2025-04-25 15:38           ` [PATCH 2/2] ci: download JGit from maven, not eclipse.org Junio C Hamano
2025-04-25 14:57 ` repo.eclipse.org outage breaking all our linux CI jobs shejialuo
2025-04-25 15:20   ` Junio C Hamano
2025-04-26 14:12     ` shejialuo
2025-04-28  6:49       ` Patrick Steinhardt
2025-04-28 10:30         ` shejialuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr01guwuq.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).