From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/3] setup: fix reinit of repos with incompatible GIT_DEFAULT_HASH
Date: Fri, 31 Jan 2025 14:40:43 -0800 [thread overview]
Message-ID: <xmqqr04i61zo.fsf@gitster.g> (raw)
In-Reply-To: <20250130-b4-pks-reinit-default-ref-format-v1-3-d2769ca01207@pks.im> (Patrick Steinhardt's message of "Thu, 30 Jan 2025 17:24:19 +0100")
Patrick Steinhardt <ps@pks.im> writes:
> The exact same issue as described in the preceding commit also exists
> for GIT_DEFAULT_HASH. Thus, reinitializing a repository that e.g. uses
> SHA1 with `GIT_DEFAULT_HASH=sha256 git init` will cause the object
> format of that repository to change to SHA256. This is of course bogus
> as any existing objects and refs will not be converted, thus causing
> repository corruption:
The exact same comment on silently ignoring applies, but unlike the
previous one, converting the entire history is far more expensive,
so it may be much less likely to be worth going the automatic
conversion route than the previous one.
Thanks.
next prev parent reply other threads:[~2025-01-31 22:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 16:24 [PATCH 0/3] setup: fix reinit of repos with different formats Patrick Steinhardt
2025-01-30 16:24 ` [PATCH 1/3] t0001: remove duplicate test Patrick Steinhardt
2025-01-30 16:24 ` [PATCH 2/3] setup: fix reinit of repos with incompatible GIT_DEFAULT_REF_FORMAT Patrick Steinhardt
2025-01-30 22:40 ` Junio C Hamano
2025-01-31 22:38 ` Junio C Hamano
2025-02-03 5:29 ` Patrick Steinhardt
2025-02-03 14:01 ` Junio C Hamano
2025-02-03 15:02 ` Patrick Steinhardt
2025-01-30 16:24 ` [PATCH 3/3] setup: fix reinit of repos with incompatible GIT_DEFAULT_HASH Patrick Steinhardt
2025-01-31 22:40 ` Junio C Hamano [this message]
2025-01-30 23:58 ` [PATCH 0/3] setup: fix reinit of repos with different formats brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr04i61zo.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).