From: Junio C Hamano <gitster@pobox.com>
To: Sam James <sam@gentoo.org>
Cc: Patrick Steinhardt <ps@pks.im>,
git@vger.kernel.org, Eli Schwartz <eschwartz@gentoo.org>
Subject: Re: [PATCH v3] meson: fix missing deps for technical articles
Date: Tue, 14 Jan 2025 11:16:02 -0800 [thread overview]
Message-ID: <xmqqr0552olp.fsf@gitster.g> (raw)
In-Reply-To: <87a5btwhyk.fsf@gentoo.org> (Sam James's message of "Tue, 14 Jan 2025 15:09:07 +0000")
Sam James <sam@gentoo.org> writes:
> Patrick Steinhardt <ps@pks.im> writes:
>
>> On Tue, Jan 14, 2025 at 02:47:10PM +0000, Sam James wrote:
>>> We need an explicit `depends: documentation_deps` so that all of our
>>> Documentation targets know they require asciidoc.conf. This shows up
>>> as parallel build failures with it not yet being available.
>>>
>>> Other targets look OK already.
>>>
>>> Signed-off-by: Sam James <sam@gentoo.org>
>>> ---
>>> v3: Fixed commit message.
>>> v2: Drop incorrect dep I'd added for api-index.sh as pointed out by Patrick.
>>
>> Thanks, this version looks good to me.
>
> Thanks, and sorry for the (obvious) errors.
Thanks, both of you, to working well together and quickly.
Will queue.
prev parent reply other threads:[~2025-01-14 19:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 14:47 [PATCH v3] meson: fix missing deps for technical articles Sam James
2025-01-14 15:01 ` Patrick Steinhardt
2025-01-14 15:09 ` Sam James
2025-01-14 19:16 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr0552olp.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=eschwartz@gentoo.org \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).