From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Patrick Steinhardt <ps@pks.im>, GIT Mailing-list <git@vger.kernel.org>
Subject: Re: 'seen' branch identifies as v2.48.0
Date: Mon, 13 Jan 2025 17:49:59 -0800 [thread overview]
Message-ID: <xmqqr0566u60.fsf@gitster.g> (raw)
In-Reply-To: <6c5d0f90-79f0-4fba-8edb-f80d0665873b@ramsayjones.plus.com> (Ramsay Jones's message of "Tue, 14 Jan 2025 01:16:01 +0000")
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> $ cat GIT-VERSION
> v2.48.0
> $
This came from semantic mismerge with Patrick's latest round of
build updates. Usually I try to review very critically parts of a
series that can negatively affect those users who do *not* use a new
feature each topic tries to add or improve, and it means for this
topic, if it breaks builds that do not involve meson, it would
automatically qualify the topic to be ejected from the tree (side
note: if a breakage is for those who use meson, as long as it is not
as grave as running an equivalent of "sudo rm -fr /", I'll let it
through), but this time because there was no textual conflict, the
hardcoded GIT-VERSION unfortunately went through.
I however somehow thought that those who are building from a
repository should get "git describe" name instead of the hardcoded
fallback name in GIT-VERSION. At least, it is my understanding that
is the intent of that series. Or are you building from a tarball
extract?
> I normally like to find solutions before posting problems to the list, but
> unfortunately I don't have time to look into this at the moment. Sorry!
>
> Just a heads up.
I'd throw it back at Patrick, at least for tonight; the topic is
more or less hot off the press and it should not be surprising it it
needed immediate fix-up and reroll.
Thanks.
next prev parent reply other threads:[~2025-01-14 1:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 1:16 'seen' branch identifies as v2.48.0 Ramsay Jones
2025-01-14 1:49 ` Junio C Hamano [this message]
2025-01-14 7:51 ` Patrick Steinhardt
2025-01-15 3:26 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr0566u60.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).