git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: "Martin Ågren" <martin.agren@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 0/3] Asciidoctor fixes for 2.48.0
Date: Sat, 21 Dec 2024 08:58:07 -0800	[thread overview]
Message-ID: <xmqqr061c6sg.fsf@gitster.g> (raw)
In-Reply-To: <Z2abxaGVzA5Kce-s@pks.im> (Patrick Steinhardt's message of "Sat, 21 Dec 2024 11:43:17 +0100")

Patrick Steinhardt <ps@pks.im> writes:

>> Thanks.  [2][3] are something we have to have before we can tag 2.48
>> to have a healthy build with the usual Makefile; so is a working
>> Asciidoctor based documentation generation, so building your doc
>> toolchain fixes on top of the fixes for 'GIT-VERSION-GEN' does not
>> give us any practical problem.
>> 
>> Thanks for a fix.  Will queue.
>
> Thanks indeed, the changes look good to me.
>
> I guess my key learning is to do largish patch series like the build
> refactorings in smaller increments next time. I considered doing it
> several times while implementing the series, but shied away from it. I
> guess it would have been easier for everyone involved and would have led
> to fewer issues though if I did split it up.

FWIW, from the project maintainer's point of view, the trickling
rate of all of your series was not overly too fast.  As long as the
reactions to problems discovered can keep up with the same rate, I
do not share the "smaller increments as we did too much too fast"
sentiment myself.

If you are referring to the fact that you have to scramble and fix
the reported breakages on multiple fronts quickly near the end of
year holiday season to keep the release candidate healthy, and
regretting that we went a little too fast, then yeah, I can
understand it and we may want to pace ourselves the next time to
lessen the stress on all of us a bit ;-)

> So thanks to all the people that are helping out in this context!

Yes, big thanks to everybody.

      reply	other threads:[~2024-12-21 16:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-20 23:18 [PATCH 0/3] Asciidoctor fixes for 2.48.0 Martin Ågren
2024-12-20 23:18 ` [PATCH 1/3] asciidoctor-extensions.rb.in: delete existing <refmiscinfo/> Martin Ågren
2024-12-21 10:42   ` Patrick Steinhardt
2024-12-20 23:18 ` [PATCH 2/3] asciidoctor-extensions.rb.in: add missing word Martin Ågren
2024-12-20 23:18 ` [PATCH 3/3] asciidoctor-extensions.rb.in: inject GIT_DATE Martin Ågren
2024-12-21  2:42 ` [PATCH 0/3] Asciidoctor fixes for 2.48.0 Junio C Hamano
2024-12-21 10:43   ` Patrick Steinhardt
2024-12-21 16:58     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr061c6sg.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=martin.agren@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).