From: Junio C Hamano <gitster@pobox.com>
To: shejialuo <shejialuo@gmail.com>
Cc: Wang Bing-hua via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Wang Bing-hua <louiswpf@gmail.com>
Subject: Re: [PATCH] remote: align --verbose output with spaces
Date: Tue, 17 Dec 2024 12:21:37 -0800 [thread overview]
Message-ID: <xmqqr066ysa6.fsf@gitster.g> (raw)
In-Reply-To: <Z2F7VAsTjfBCVCrG@ArchLinux> (shejialuo@gmail.com's message of "Tue, 17 Dec 2024 21:23:32 +0800")
shejialuo <shejialuo@gmail.com> writes:
> On Tue, Dec 17, 2024 at 12:39:36PM +0000, Wang Bing-hua via GitGitGadget wrote:
>> From: Wang Bing-hua <louiswpf@gmail.com>
>>
>> Remote names exceeding a tab width could cause misalignment.
If all of them are named with ten ASCII characters, on a terminal
with fixed-width font, things will still display aligned ;-)
>> Align --verbose output with spaces instead of a tab.
>>
>
> Good enhancement.
With a Devil's advocate hat on, a change like this will completely
break tools when they are reading the "--verbose" output and
expecting that the fields are separated with a TAB (in other words,
the tab is *not* about alignment in the first place for them).
Now with that hat off.
For users with that many remotes where the alignment of URLs in the
interactive "git remote -v" output matter, I am not sure if this
change is a real improvement enough that it is worth the possible
risk of breaking existing tools. With that many remotes defined,
wouldn't they be doing "git remote -v" piped to "grep '^name<TAB>'"
or something? That use case would break with the change, too.
Thanks.
next prev parent reply other threads:[~2024-12-17 20:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 12:39 [PATCH] remote: align --verbose output with spaces Wang Bing-hua via GitGitGadget
2024-12-17 13:23 ` shejialuo
2024-12-17 15:24 ` Wang Bing-hua
2024-12-17 20:21 ` Junio C Hamano [this message]
2024-12-18 5:49 ` Wang Bing-hua
2024-12-18 13:52 ` shejialuo
2024-12-18 14:09 ` Wang Bing-hua
2024-12-17 17:18 ` [PATCH v2] " Wang Bing-hua via GitGitGadget
2024-12-17 20:47 ` Junio C Hamano
2024-12-18 8:37 ` Wang Bing-hua
2024-12-18 15:39 ` Junio C Hamano
2024-12-19 2:14 ` Wang Bing-hua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr066ysa6.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=louiswpf@gmail.com \
--cc=shejialuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).