git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Patrick Steinhardt <ps@pks.im>,
	 Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>,
	 git@vger.kernel.org,  Eric Sunshine <sunshine@sunshineco.com>,
	 Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH v2] fast-import: disallow "." and ".." path components
Date: Thu, 28 Nov 2024 08:07:33 +0900	[thread overview]
Message-ID: <xmqqr06ws2bu.fsf@gitster.g> (raw)
In-Reply-To: <20241127142458.GA1712@coredump.intra.peff.net> (Jeff King's message of "Wed, 27 Nov 2024 09:24:58 -0500")

Jeff King <peff@peff.net> writes:

> I had the same thought, but I think the right code to be using is
> verify_path(). That's what ultimately is used to let names into the
> index from trees, from update-index, or from other tools like git-apply.

Yeah, I agree that is the right helper to use.

  reply	other threads:[~2024-11-27 23:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-25 17:58 [PATCH] fast-import: disallow "." and ".." path components Elijah Newren via GitGitGadget
2024-11-25 18:15 ` Eric Sunshine
2024-11-25 18:24   ` Elijah Newren
2024-11-25 19:00 ` [PATCH v2] " Elijah Newren via GitGitGadget
2024-11-26  6:57   ` Patrick Steinhardt
2024-11-27 14:24     ` Jeff King
2024-11-27 23:07       ` Junio C Hamano [this message]
2024-11-27  8:28   ` Kristoffer Haugsbakk
2024-11-27 13:23     ` Re* " Junio C Hamano
2024-11-27 19:41       ` Eric Sunshine
2024-11-28  0:36       ` [PATCH v2] CodingGuidelines: a handful of error message guidelines Junio C Hamano
2024-11-28  7:57         ` Eric Sunshine
2024-11-28  9:28           ` Junio C Hamano
2024-11-28  9:51             ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr06ws2bu.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=newren@gmail.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).