From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: blanet via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, blanet <bupt_xingxin@163.com>,
Xing Xin <xingxin.xx@bytedance.com>
Subject: Re: [PATCH] diff-tree: fix crash when used with --remerge-diff
Date: Thu, 08 Aug 2024 10:24:00 -0700 [thread overview]
Message-ID: <xmqqr0azgc7j.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BGo7-P+3w=Y2Mifox4xztzMhgLKBtnrrF9R1XM9ZDPqqw@mail.gmail.com> (Elijah Newren's message of "Thu, 8 Aug 2024 09:03:53 -0700")
Elijah Newren <newren@gmail.com> writes:
> The commit message from my patch also included an explanation for why
> diff-tree was the only caller that was missing the necessary logic
> (see the last paragraph, which kind of references the one before it as
> well).
... which we may want to resurrect.
> Test looks good too.
>
> I'll be happy to add my Reviewed-by if you fix the header include order.
Thanks for a review.
next prev parent reply other threads:[~2024-08-08 17:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 13:20 [PATCH] diff-tree: fix crash when used with --remerge-diff blanet via GitGitGadget
2024-08-08 16:03 ` Elijah Newren
2024-08-08 17:24 ` Junio C Hamano [this message]
2024-08-09 7:25 ` Xing Xin
2024-08-09 7:24 ` [PATCH v2] " blanet via GitGitGadget
2024-08-09 15:32 ` Junio C Hamano
2024-08-09 15:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr0azgc7j.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=bupt_xingxin@163.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=newren@gmail.com \
--cc=xingxin.xx@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).