git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"Jean-Noël Avila" <jn.avila@free.fr>
Cc: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>,
	git@vger.kernel.org, "Jean-Noël Avila" <jn.avila@free.fr>,
	"Ramsay Jones" <ramsay@ramsayjones.plus.com>
Subject: Re: [PATCH v2] asciidoctor: fix `synopsis` rendering
Date: Tue, 23 Jul 2024 09:43:14 -0700	[thread overview]
Message-ID: <xmqqr0bk2h5p.fsf@gitster.g> (raw)
In-Reply-To: <a1d70653-182e-e063-5438-2b3179d011f7@gmx.de> (Johannes Schindelin's message of "Tue, 23 Jul 2024 16:19:00 +0200 (CEST)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Hmm. This adds a "template" for no other reason than to appease the rule
> that all `.html` files in `Documentation/` _must_ be generated. Typically,
> templates are only added if anything in them needs to be interpolated to
> reflect the particular build, which is not the case here.

Consider that we leave the door open for future enhancements (like,
lose the conditional compilation and instead make it an empty file
when AsciiDoc and not asciidoctor is in use).

> Have you considered one of these alternatives?

No, because I am not interested in anything more elaborate a few
days before tagging -rc2.  If this is not meant for the upcoming
release, then I am all ears (and eyes), but otherwise, let's just do
the simplest and the most obvious thing to unbreak users for the
upcoming release and leave a more elaborate engineering to next
cycle.

Jean-Noël is planning to undo the overly elaborate mark-up and that
may eliminate the need to work around "<code> in <pre> is made into
a block element" behaviour of default asciidoctor style in the first
place, so the longer term plan should take that into account as well.

Thanks.

      reply	other threads:[~2024-07-23 16:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-20 20:30 [PATCH] asciidoctor: fix `synopsis` rendering Johannes Schindelin via GitGitGadget
2024-07-20 23:01 ` Junio C Hamano
2024-07-21  0:01   ` Junio C Hamano
2024-07-22 16:27     ` Junio C Hamano
2024-07-22 20:25 ` [PATCH v2] " Johannes Schindelin via GitGitGadget
2024-07-22 20:45   ` Junio C Hamano
2024-07-23  3:13     ` Junio C Hamano
2024-07-23 14:19     ` Johannes Schindelin
2024-07-23 16:43       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr0bk2h5p.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=jn.avila@free.fr \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).