From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "René Scharfe" <l.s.r@web.de>, "Git List" <git@vger.kernel.org>,
"Chandra Pratap" <chandrapratap376@gmail.com>,
"Chandra Pratap" <chandrapratap3519@gmail.com>,
"Kyle Lippincott" <spectral@google.com>,
"John Cai" <johncai86@gmail.com>
Subject: Re: [PATCH 3/2] commit: remove find_header_mem()
Date: Thu, 20 Jun 2024 11:12:37 -0700 [thread overview]
Message-ID: <xmqqr0crv5yi.fsf@gitster.g> (raw)
In-Reply-To: <20240619173106.GA1519400@coredump.intra.peff.net> (Jeff King's message of "Wed, 19 Jun 2024 13:31:06 -0400")
Jeff King <peff@peff.net> writes:
>> +const char *find_commit_header(const char *msg, const char *key, size_t *out_len)
>> {
>> int key_len = strlen(key);
>> const char *line = msg;
>
> Not new in your patch, but assigning strlen() to int tingled my
> spider-sense. It's OK, though, because "key" is always a small string
> literal.
Yup. All callers of find_commit_header() give in-program constants
and never an externally sourced random string there.
> So the conversion looks good to me.
Thanks. Will queue.
next prev parent reply other threads:[~2024-06-20 18:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 20:36 [PATCH 1/2] receive-pack: use find_commit_header() in check_cert_push_options() René Scharfe
2024-02-09 20:41 ` [PATCH 2/2] receive-pack: use find_commit_header() in check_nonce() René Scharfe
2024-02-09 22:18 ` Junio C Hamano
2024-06-19 17:13 ` [PATCH 3/2] commit: remove find_header_mem() René Scharfe
2024-06-19 17:31 ` Jeff King
2024-06-20 18:12 ` Junio C Hamano [this message]
2024-02-09 22:11 ` [PATCH 1/2] receive-pack: use find_commit_header() in check_cert_push_options() Junio C Hamano
2024-02-10 7:42 ` René Scharfe
2024-02-12 16:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr0crv5yi.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chandrapratap3519@gmail.com \
--cc=chandrapratap376@gmail.com \
--cc=git@vger.kernel.org \
--cc=johncai86@gmail.com \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
--cc=spectral@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).