* t0211-trace2-perf.sh: typo patern -> pattern
@ 2024-05-15 14:35 Marcel Telka
2024-05-15 16:52 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Marcel Telka @ 2024-05-15 14:35 UTC (permalink / raw)
To: git
Hi,
There seems to be apparent typo in the t/t0211-trace2-perf.sh file:
--- a/t/t0211-trace2-perf.sh
+++ b/t/t0211-trace2-perf.sh
@@ -233,7 +233,7 @@ have_counter_event () {
pattern="d0|${thread}|${event}||||${category}|name:${name} value:${value}" &&
- grep "${patern}" ${file}
+ grep "${pattern}" ${file}
}
test_expect_success 'global counter test/test1' '
Thanks.
--
+-------------------------------------------+
| Marcel Telka e-mail: marcel@telka.sk |
| homepage: http://telka.sk/ |
+-------------------------------------------+
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: t0211-trace2-perf.sh: typo patern -> pattern
2024-05-15 14:35 t0211-trace2-perf.sh: typo patern -> pattern Marcel Telka
@ 2024-05-15 16:52 ` Junio C Hamano
2024-05-15 16:59 ` Jeff Hostetler
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2024-05-15 16:52 UTC (permalink / raw)
To: Marcel Telka; +Cc: git, Jeff Hostetler
Marcel Telka <marcel@telka.sk> writes:
> Hi,
>
> There seems to be apparent typo in the t/t0211-trace2-perf.sh file:
>
>
> --- a/t/t0211-trace2-perf.sh
> +++ b/t/t0211-trace2-perf.sh
> @@ -233,7 +233,7 @@ have_counter_event () {
>
> pattern="d0|${thread}|${event}||||${category}|name:${name} value:${value}" &&
>
> - grep "${patern}" ${file}
> + grep "${pattern}" ${file}
> }
>
> test_expect_success 'global counter test/test1' '
Ah, indeed, there is no assignment to the variable $patern so this
grep matches by looking for all the empty strings in the file X-<.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: t0211-trace2-perf.sh: typo patern -> pattern
2024-05-15 16:52 ` Junio C Hamano
@ 2024-05-15 16:59 ` Jeff Hostetler
2024-05-15 17:09 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Hostetler @ 2024-05-15 16:59 UTC (permalink / raw)
To: Junio C Hamano, Marcel Telka; +Cc: git, Jeff Hostetler
On 5/15/24 12:52 PM, Junio C Hamano wrote:
> Marcel Telka <marcel@telka.sk> writes:
>
>> Hi,
>>
>> There seems to be apparent typo in the t/t0211-trace2-perf.sh file:
>>
>>
>> --- a/t/t0211-trace2-perf.sh
>> +++ b/t/t0211-trace2-perf.sh
>> @@ -233,7 +233,7 @@ have_counter_event () {
>>
>> pattern="d0|${thread}|${event}||||${category}|name:${name} value:${value}" &&
>>
>> - grep "${patern}" ${file}
>> + grep "${pattern}" ${file}
>> }
>>
>> test_expect_success 'global counter test/test1' '
>
> Ah, indeed, there is no assignment to the variable $patern so this
> grep matches by looking for all the empty strings in the file X-<.
>
>
OOPS.
Thanks for the fix.
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: t0211-trace2-perf.sh: typo patern -> pattern
2024-05-15 16:59 ` Jeff Hostetler
@ 2024-05-15 17:09 ` Junio C Hamano
0 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2024-05-15 17:09 UTC (permalink / raw)
To: Jeff Hostetler; +Cc: Marcel Telka, git, Jeff Hostetler
Jeff Hostetler <git@jeffhostetler.com> writes:
> On 5/15/24 12:52 PM, Junio C Hamano wrote:
>> Marcel Telka <marcel@telka.sk> writes:
>>
>>> Hi,
>>>
>>> There seems to be apparent typo in the t/t0211-trace2-perf.sh file:
>>>
>>>
>>> --- a/t/t0211-trace2-perf.sh
>>> +++ b/t/t0211-trace2-perf.sh
>>> @@ -233,7 +233,7 @@ have_counter_event () {
>>> pattern="d0|${thread}|${event}||||${category}|name:${name}
>>> value:${value}" &&
>>> - grep "${patern}" ${file}
>>> + grep "${pattern}" ${file}
>>> }
>>> test_expect_success 'global counter test/test1' '
>> Ah, indeed, there is no assignment to the variable $patern so this
>> grep matches by looking for all the empty strings in the file X-<.
>>
>
> OOPS.
>
> Thanks for the fix.
Nobody sent an applicable patch yet, though ;-)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-15 17:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-15 14:35 t0211-trace2-perf.sh: typo patern -> pattern Marcel Telka
2024-05-15 16:52 ` Junio C Hamano
2024-05-15 16:59 ` Jeff Hostetler
2024-05-15 17:09 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).