git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Michal Suchánek" <msuchanek@suse.de>
Cc: Harmen Stoppels via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org,  Harmen Stoppels <me@harmenstoppels.nl>
Subject: Re: [PATCH] rebase: make warning less passive aggressive
Date: Wed, 21 Feb 2024 09:56:20 -0800	[thread overview]
Message-ID: <xmqqr0h5og57.fsf@gitster.g> (raw)
In-Reply-To: <20240221173822.GA9696@kitsune.suse.cz> ("Michal Suchánek"'s message of "Wed, 21 Feb 2024 18:38:22 +0100")

Michal Suchánek <msuchanek@suse.de> writes:

> Or if it does touch the po files it could as well update the
> translations.
>
> There are changes that can be trivially translated without any knowledge
> of the target language.

You need to know the target language before deciding it is OK and
sufficient to just remove ̉¿? from around a sentence to make it from
a question to a statement of a fact.  You may know enough, but
reviewers may not be.  In addition, it would allow bypassing the
language teams, which is the most serious problem I see in such an
attitude.

  reply	other threads:[~2024-02-21 17:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-20 15:23 [PATCH] rebase: make warning less passive aggressive Harmen Stoppels via GitGitGadget
2024-02-20 17:29 ` Junio C Hamano
2024-02-21 17:38   ` Michal Suchánek
2024-02-21 17:56     ` Junio C Hamano [this message]
2024-02-21 18:02       ` Junio C Hamano
2024-02-21 18:30         ` Michal Suchánek
2024-02-21 22:05           ` Jean-Noël AVILA
2024-02-21 22:46             ` Junio C Hamano
2024-02-22  1:43               ` Junio C Hamano
2024-02-22 10:01               ` Jean-Noël AVILA
2024-02-22 11:04                 ` Michal Suchánek
2024-02-22 16:46                 ` Junio C Hamano
2024-02-21  7:14 ` Patrick Steinhardt
2024-02-21 17:31   ` Junio C Hamano
2024-02-21 17:38 ` [PATCH v2] " Harmen Stoppels via GitGitGadget
2024-02-22  8:15   ` Patrick Steinhardt
2024-02-22 10:53   ` Kristoffer Haugsbakk
2024-02-22 17:00     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr0h5og57.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=me@harmenstoppels.nl \
    --cc=msuchanek@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).