git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Isoken Ibizugbe <isokenjune@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] branch.c: adjust error messages to coding guidelines
Date: Fri, 13 Oct 2023 11:29:20 -0700	[thread overview]
Message-ID: <xmqqr0lyz88v.fsf@gitster.g> (raw)
In-Reply-To: <CAJHH8bE15VotFy7QQ-Npmfk9ePvf=-h5SP+Q8phrDBRj8Ti=hQ@mail.gmail.com> (Isoken Ibizugbe's message of "Fri, 13 Oct 2023 16:40:01 +0100")

Isoken Ibizugbe <isokenjune@gmail.com> writes:

> I am sorry if I made any mistakes, It's my first time using
> gitgitgadget. This commit was already sent before through git-send
> email. The patch was intended to submit the revisions.

I cannot help with GGG, but it looked strange for this change to be
in two patches, especially since what the rule of deciding which
message is to be touched in which one of the two patches were not
explained anywhere in the series.

I suspect what you want to do is to squash these two commits down
into a single commit, review the resulting code change and also the
commit log message to see if the latter still matches what the
combined patch does, update them as needed, run the test suite
again.

And then format-patch without the cover letter to send the resulting
patch out.  Or force push to tell GGG to resend a new iteration
without any cover letter.

Thanks.

  reply	other threads:[~2023-10-13 18:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-13 15:33 [PATCH 0/2] [Outreachy][PATCH v2] branch.c: adjust error messages to coding guidelines Isoken June Ibizugbe via GitGitGadget
2023-10-13 15:33 ` [PATCH 1/2] branch.c: ammend error messages for die() Isoken June Ibizugbe via GitGitGadget
2023-10-13 15:33 ` [PATCH 2/2] branch.c: adjust error messages to coding guidelines Isoken June Ibizugbe via GitGitGadget
2023-10-13 15:40   ` Isoken Ibizugbe
2023-10-13 18:29     ` Junio C Hamano [this message]
2023-10-13 18:25   ` Rubén Justo
2023-10-13 18:30 ` [PATCH 0/2] [Outreachy][PATCH v2] " Rubén Justo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr0lyz88v.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=isokenjune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).