git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: ach.lumap@gmail.com, git@vger.kernel.org, christian.couder@gmail.com
Subject: Re: [PATCH 1/1] t2400: avoid using pipes
Date: Tue, 03 Oct 2023 11:42:30 -0700	[thread overview]
Message-ID: <xmqqr0mbzgx5.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cSkZ_brRh_ijFRgz3sP9ou5se9-xeRg=C+cV3c3-v3Wtg@mail.gmail.com> (Eric Sunshine's message of "Tue, 3 Oct 2023 14:01:13 -0400")

Eric Sunshine <sunshine@sunshineco.com> writes:

> On Tue, Oct 3, 2023 at 1:49 PM <ach.lumap@gmail.com> wrote:
>> t2400: avoid using pipes
>
> Pipes themselves are not necessarily problematic, and there are many
> places in the test suite where they are legitimately used. Rather...
> ...
> readers of `git log --oneline` (or other such commands), a better
> subject for the patch might be:
>
>     t2400: avoid losing Git exit code
>
> That minor comment aside (which is probably not worth a reroll), the
> commit message properly explains why this change is desirable and the
> patch itself looks good.

Thanks for writing and reviewing.  Will queue.

  reply	other threads:[~2023-10-03 18:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-03 17:48 [PATCH 0/1] *** Avoid using Pipes *** ach.lumap
2023-10-03 17:48 ` [PATCH 1/1] t2400: avoid using pipes ach.lumap
2023-10-03 18:01   ` Eric Sunshine
2023-10-03 18:42     ` Junio C Hamano [this message]
2023-11-30 16:54 ` [PATCH v2 0/1] *** Avoid using Pipes *** Achu Luma
2023-11-30 16:54   ` [PATCH v2 1/1] t2400: avoid using pipes Achu Luma
2023-11-30 18:16     ` Christian Couder
2023-12-04 15:37       ` [Outreachy][PATCH v3] " Achu Luma
2023-12-08 21:00         ` Junio C Hamano
2024-01-20  2:15         ` [Outreachy][PATCH v4] t2400: avoid losing exit status to pipes Achu Luma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr0mbzgx5.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ach.lumap@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).