From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1B7DC433F5 for ; Sun, 13 Feb 2022 06:14:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233924AbiBMGOU (ORCPT ); Sun, 13 Feb 2022 01:14:20 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:46868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231859AbiBMGOS (ORCPT ); Sun, 13 Feb 2022 01:14:18 -0500 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFCA35E77B for ; Sat, 12 Feb 2022 22:14:12 -0800 (PST) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 51478101646; Sun, 13 Feb 2022 01:14:09 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=cYGcqEfMQl+UPO7BsFdAGGhX665BxQcEYgHwQL 9jP2o=; b=vk9kFmb4nRPjzH02vf2ematP02fKK86UyOyFUfEYoN7neu/5Zrza24 8+RiXgNuhktvJj1gItUvyAI50AcmEX78Z4vppqxzbFbVioHQualK2aoJ4YZCMrD/ IlTjwiGDUWaOrtFbQh5dwQkvm2vdaKQuT1gwx4iv9JSZv0eJy90WI= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 48AE4101642; Sun, 13 Feb 2022 01:14:09 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.185.212.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 9D799101640; Sun, 13 Feb 2022 01:14:08 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Glen Choo Cc: git@vger.kernel.org, Atharva Raykar , Christian Couder , Emily Shaffer , Jonathan Nieder , Kaartic Sivaraam , pc44800@gmail.com, Shourya Shukla , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Subject: Re: [PATCH v7 00/20] submodule: convert the rest of 'update' to C References: <20220208083952.35036-1-chooglen@google.com> <20220210092833.55360-1-chooglen@google.com> Date: Sat, 12 Feb 2022 22:14:07 -0800 In-Reply-To: (Junio C. Hamano's message of "Sat, 12 Feb 2022 21:54:02 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 27750108-8C94-11EC-8960-5E84C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Junio C Hamano writes: > Glen Choo writes: > >> This reroll contains another 'easy' preparatory patch and the fixups I >> alluded to in v6 [1]. This isn't the split-up I described in the >> footnote of v6, but it gets the big patch (patch 17) to what I think is >> a reviewable state. > > Thanks. > > This seems to heavily conflict with "clone, submodule: pass partial > clone filters to submodules, 2022-02-04" by Josh Steadmon > <690d2316ad518ea4551821b2b3aa652996858475.1644034886.git.steadmon@google.com> > in both builtins/submodule--helper.c and git-submodule.sh. > > It also removes the code that "submodule: record superproject gitdir > during 'update', 2022-02-03" by Emily Shaffer > <20220203215914.683922-5-emilyshaffer@google.com>, so what the other > topic ends up adding to the shell script needs to eventually be > redone in the C code. > > I think "superproject aware" topic would see a reroll due to a > slight redesign. I am not sure how solid the design of the > "pass down partial clone filter" topic is at this moment. > > I may try to eject them tentatively and see how well this topic > plays with the rest of the topics in flight. > > Thanks. I can merge this to seen minus the above two topics and get it compile, but it also seems to have some interaction with 961b130d (branch: add --recurse-submodules option for branch creation, 2022-01-28) and makes the t3207, tests added by that other topic, fail X-<.