From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A31C6C433EF
	for <git@archiver.kernel.org>; Tue, 14 Dec 2021 00:31:08 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S242430AbhLNAbH (ORCPT <rfc822;git@archiver.kernel.org>);
        Mon, 13 Dec 2021 19:31:07 -0500
Received: from pb-smtp20.pobox.com ([173.228.157.52]:61892 "EHLO
        pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S240612AbhLNAbH (ORCPT <rfc822;git@vger.kernel.org>);
        Mon, 13 Dec 2021 19:31:07 -0500
Received: from pb-smtp20.pobox.com (unknown [127.0.0.1])
        by pb-smtp20.pobox.com (Postfix) with ESMTP id CB62316211E;
        Mon, 13 Dec 2021 19:31:06 -0500 (EST)
        (envelope-from junio@pobox.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; s=sasl; bh=pbdcHJiNrSsXuAVpVYK96lu4Xg7cwr7X2HHHxz
        f9ZT4=; b=aYDKFizljDyU8vZ6ptGGmuFEKN62F1S8PUKVu5aOuMFFrvEg1ED/Z4
        YwIJw2NUtnHjEVS9nJizAE3VGWUADJ2U2GwpVWwvH4uEYdwVFYTSkAs56thKI21B
        rFm6ztcwOZRK+Yn+ZT9CCnxtGhTeVw4so0k98ZoNH6a6HK4Z8hjcY=
Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1])
        by pb-smtp20.pobox.com (Postfix) with ESMTP id C355116211D;
        Mon, 13 Dec 2021 19:31:06 -0500 (EST)
        (envelope-from junio@pobox.com)
Received: from pobox.com (unknown [104.133.2.91])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 24AC816211A;
        Mon, 13 Dec 2021 19:31:03 -0500 (EST)
        (envelope-from junio@pobox.com)
From:   Junio C Hamano <gitster@pobox.com>
To:     =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason <avarab@gmail.com>
Cc:     git@vger.kernel.org, Phillip Wood <phillip.wood123@gmail.com>,
        Jeff King <peff@peff.net>, Dan Jacques <dnj@google.com>,
        Eric Wong <e@80x24.org>, Jonathan Nieder <jrnieder@gmail.com>,
        Mike Hommey <mh@glandium.org>,
        =?utf-8?B?xJBvw6BuIFRy4bqnbiBDw7RuZw==?= Danh 
        <congdanhqx@gmail.com>
Subject: Re: [PATCH v4 14/23] Makefile: re-add and use the "shellquote" macros
References: <cover-v3-00.23-00000000000-20211116T114334Z-avarab@gmail.com>
        <cover-v4-00.23-00000000000-20211117T101807Z-avarab@gmail.com>
        <patch-v4-14.23-13cbb851d32-20211117T101807Z-avarab@gmail.com>
        <xmqq4k7c9k68.fsf@gitster.g>
Date:   Mon, 13 Dec 2021 16:31:01 -0800
In-Reply-To: <xmqq4k7c9k68.fsf@gitster.g> (Junio C. Hamano's message of "Mon,
        13 Dec 2021 15:09:19 -0800")
Message-ID: <xmqqr1ag81tm.fsf@gitster.g>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: 1E57F098-5C75-11EC-972E-F327CE9DA9D6-77302942!pb-smtp20.pobox.com
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Junio C Hamano <gitster@pobox.com> writes:

> All of the above may very well explain why we decided not to use
> $(call shellquote) in the past, and it may also explain why it is
> safe to start using it again today, but it does not explain why we
> want to do so in the first place.
>
> Having to write
>
> 	$(call shellquote,$(VAR))
>
> in longhand is much more cumbersome to read, write and merge than
> defining a prepackaged VAR_SQ just once and refer it as
>
> 	'$(VAR_SQ)'
>
> everywhere.

Having said all that, I would not have minded if this change were
more isolated and turned things like

CHAINLINTTMP_SQ = $(subst ','\'',$(CHAINLINTTMP))

to use the $(call shellquote) mechanism, if all of us found it
easier to read than repeating the same line-noise substitutions for
many variables.

What was irritating was primarily that the patch went one step
further to eliminate the _SQ variant variables, making the resulting
sites that use them harder to read and understand.