From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Robert Estelle via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Robert Estelle <robert.estelle@gmail.com>,
Robert Estelle <robertestelle@gmail.com>
Subject: Re: [PATCH 2/2] color: support "default" to restore fg/bg color
Date: Mon, 25 Oct 2021 15:49:27 -0700 [thread overview]
Message-ID: <xmqqr1c8zpmw.fsf@gitster.g> (raw)
In-Reply-To: <YXcyJBmRvIEVSiaM@camp.crustytoothpaste.net> (brian m. carlson's message of "Mon, 25 Oct 2021 22:39:32 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> For an example of why this differs from white on black, let me mention
> that I use a semi-transparent terminal, where a black background is
> opaque black, and the default is semi-transparent. I assume other
> possibilities include patterned backgrounds (Enlightenment, anyone?).
> Whether you want to include something to this effect in the commit
> message is up to you, but I provide it for the interested reader.
It would help support the description of the cause, I would think.
I am also OK with these changes. [1/2] is good for completeness,
and being able to say "go back to the default" without having to
know what the default is with [2/2] is also a good change.
Thanks, both.
next prev parent reply other threads:[~2021-10-25 22:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 22:32 [PATCH 0/2] color: support "default" to restore fg/bg color Robert Estelle via GitGitGadget
2021-10-25 22:32 ` [PATCH 1/2] color: add missing GIT_COLOR_* white/black constants Robert Estelle via GitGitGadget
2021-10-25 22:32 ` [PATCH 2/2] color: support "default" to restore fg/bg color Robert Estelle via GitGitGadget
2021-10-25 22:39 ` brian m. carlson
2021-10-25 22:49 ` Junio C Hamano [this message]
2021-10-26 0:54 ` Robert Estelle
2021-10-28 16:41 ` Junio C Hamano
2021-10-28 17:33 ` Robert Estelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr1c8zpmw.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=robert.estelle@gmail.com \
--cc=robertestelle@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).