From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: "Felipe Contreras" <felipe.contreras@gmail.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Jeff King" <peff@peff.net>,
"Git Mailing List" <git@vger.kernel.org>,
"Johannes Sixt" <j6t@kdbg.org>,
"Sergey Organov" <sorganov@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] xdiff: implement a zealous diff3
Date: Tue, 15 Jun 2021 13:03:40 +0900 [thread overview]
Message-ID: <xmqqr1h3wz8j.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BFY7uU5Ugypv4xCHq+XHTc3UROWPdV1v-JbN7xBycDZTA@mail.gmail.com> (Elijah Newren's message of "Mon, 14 Jun 2021 20:43:54 -0700")
Elijah Newren <newren@gmail.com> writes:
> This is going to sound harsh, but people shouldn't waste (any more)
> time reviewing the patches in this thread or the "merge: cleanups and
> fix" series submitted elsewhere. They should all just be rejected.
>
> I do not think it is reasonable to expect reviewers to spend time
> responding to re-posted patches when:
> * no attempt was made to make sure they were up-to-date with current
> code beyond compiling (see below)
> * no attempt was made to address missing items pointed out in
> response to the original submission[1]
> * no attempt was made to handle or even test particular cases
> pointed out in response to the original submission (see [1] and below)
> * the patches were posted despite knowing they caused segfaults, and
> without even stating as much![2]
> * the segfault "fixes" are submitted as a separate series from the
> patch introducing the segfault[3], raising the risk that one gets
> picked up without the other.
Fair enough. Thanks.
next prev parent reply other threads:[~2021-06-15 4:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 14:31 [PATCH] xdiff: implement a zealous diff3 Felipe Contreras
2021-06-13 15:42 ` Jeff King
2021-06-13 18:00 ` Felipe Contreras
2021-06-13 21:24 ` Felipe Contreras
2021-06-15 2:07 ` Junio C Hamano
2021-06-15 3:43 ` Elijah Newren
2021-06-15 4:03 ` Junio C Hamano [this message]
2021-06-15 9:20 ` Felipe Contreras
2021-06-15 9:16 ` Felipe Contreras
2021-06-15 16:59 ` Elijah Newren
2021-06-14 4:44 ` Jeff King
2021-06-15 4:19 ` Felipe Contreras
2021-06-15 9:24 ` Jeff King
2021-06-15 10:24 ` Felipe Contreras
-- strict thread matches above, loose matches on Subject: below --
2013-03-06 20:03 feature suggestion: optimize common parts for checkout --conflict=diff3 Jeff King
2013-03-06 20:36 ` [PATCH] xdiff: implement a zealous diff3 Uwe Kleine-König
2013-03-06 20:46 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr1h3wz8j.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=sorganov@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).