git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Alexey via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Alexey <lesha.ogonkov@gmail.com>
Subject: Re: [PATCH] Fix zsh installation instructions
Date: Mon, 06 Jul 2020 15:42:18 -0700	[thread overview]
Message-ID: <xmqqr1to8dv9.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <pull.814.git.git.1593687080695.gitgitgadget@gmail.com> (Alexey via GitGitGadget's message of "Thu, 02 Jul 2020 10:51:20 +0000")

> From: Alexey <lesha.ogonkov@gmail.com>

Thanks.

Any zsh users raise their hands?  Does this change look sane?

> - Fix wrong script in completion configuration. zsh wants bash completion
>   path here, not path to itself.
> - Add `compinit` autoload command, since whole thing didn't work
>   if it is not loaded.
>
> Signed-off-by: Alexey <lesha.ogonkov@gmail.com>
> ---
>     Fix zsh installation instructions
>     
>      * Fix wrong script in completion configuration. zsh wants bash
>        completion path here, not path to itself.
>      * Add compinit autoload command, since whole thing didn't work if it is
>        not loaded.
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-814%2Fogonkov%2Fpatch-1-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-814/ogonkov/patch-1-v1
> Pull-Request: https://github.com/git/git/pull/814
>
>  contrib/completion/git-completion.zsh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh
> index ce47e86b60..107869036d 100644
> --- a/contrib/completion/git-completion.zsh
> +++ b/contrib/completion/git-completion.zsh
> @@ -9,13 +9,14 @@
>  #
>  # If your script is somewhere else, you can configure it on your ~/.zshrc:
>  #
> -#  zstyle ':completion:*:*:git:*' script ~/.git-completion.zsh
> +#  zstyle ':completion:*:*:git:*' script ~/.git-completion.bash
>  #
>  # The recommended way to install this script is to make a copy of it in
>  # ~/.zsh/ directory as ~/.zsh/git-completion.zsh and then add the following
>  # to your ~/.zshrc file:
>  #
>  #  fpath=(~/.zsh $fpath)
> +#  autoload -Uz compinit && compinit
>  
>  complete ()
>  {
>
> base-commit: a08a83db2bf27f015bec9a435f6d73e223c21c5e

  reply	other threads:[~2020-07-06 22:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 10:51 [PATCH] Fix zsh installation instructions Alexey via GitGitGadget
2020-07-06 22:42 ` Junio C Hamano [this message]
2020-10-14 15:10   ` Stefan Haller
2020-10-16 17:06     ` Junio C Hamano
2020-10-25  3:29     ` Felipe Contreras
2020-10-27  8:29       ` Stefan Haller
2020-10-27  8:32       ` Stefan Haller
2020-10-27  8:59         ` Лёша Огоньков
2020-10-27 20:00           ` Junio C Hamano
2020-10-28  1:45             ` Felipe Contreras
2020-10-29 17:50               ` Junio C Hamano
2020-10-29 19:09                 ` Junio C Hamano
2020-11-02 20:49                 ` Felipe Contreras
2020-11-02 20:54                   ` Felipe Contreras
2020-11-03  1:02                     ` Junio C Hamano
2020-11-02 22:37                   ` Junio C Hamano
2020-10-28  1:31           ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr1to8dv9.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=lesha.ogonkov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).