git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Andrei Rybak <rybak.a.v@gmail.com>
Cc: git@vger.kernel.org, sunshine@sunshineco.com
Subject: Re: [PATCH v2 2/2] t: fix whitespace around &&
Date: Sun, 22 Mar 2020 16:45:37 -0700	[thread overview]
Message-ID: <xmqqr1xk6jj2.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200322211422.15129-2-rybak.a.v@gmail.com> (Andrei Rybak's message of "Sun, 22 Mar 2020 22:14:22 +0100")

Andrei Rybak <rybak.a.v@gmail.com> writes:

> Add missing spaces before '&&' and switch tabs around '&&' to spaces.

The latter is especially appreciated---people just don't pay
attention and it is much harder to spot with eyeballs than the
former.

> Also fix the space after redirection operator in t3701 while we're here.

I started writing "hmm, doesn't it belong to the previous step" and
then realized that this one is a bat between animals and birds ;-)

Thanks.

      reply	other threads:[~2020-03-22 23:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-15 18:09 [PATCH] t: fix whitespace around && Andrei Rybak
2020-03-15 18:20 ` Eric Sunshine
2020-03-15 18:35   ` Andrei Rybak
2020-03-15 18:38     ` Eric Sunshine
2020-03-22 21:14 ` [PATCH v2 1/2] t9500: remove spaces after redirect operators Andrei Rybak
2020-03-22 21:14   ` [PATCH v2 2/2] t: fix whitespace around && Andrei Rybak
2020-03-22 23:45     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr1xk6jj2.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=rybak.a.v@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).