git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Bárbara de Castro Fernandes" <barbara.fernandes@usp.br>,
	"Robert Dailey" <rcdailey.lists@gmail.com>,
	"Taylor Blau" <me@ttaylorr.com>, Git <git@vger.kernel.org>
Subject: Re: Feature request: Add --no-edit to git tag command
Date: Fri, 12 Apr 2019 11:32:25 +0900	[thread overview]
Message-ID: <xmqqr2a8ymva.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190411182903.GA32528@sigill.intra.peff.net> (Jeff King's message of "Thu, 11 Apr 2019 14:29:03 -0400")

Jeff King <peff@peff.net> writes:

> On Thu, Apr 11, 2019 at 03:20:52PM -0300, Bárbara de Castro Fernandes wrote:
>
>> This new proposed --amend option, although semantically different,
>> would have a very similar functionality to the already existing -f
>> option. So should we, perhaps, change -f's behavior to treat the tag
>> as a new one, treating the old one as if it never existed (as I think
>> Junio was saying)? By this I mean the command should fail if the user
>> doesn't give a SHA-1 and the previous message wouldn't be preloaded.
>> --amend, on the other hand, would give the user an opportunity to
>> revise the tag by opening, by default, the editor with the
>> pre-existing message unless given the '--no-edit' option, and if not
>> given a SHA-1 it would keep on using the previous one.
>
> Yes, that's what I'd expect it to do (so yes, it's also different from
> "-f" in that it defaults to the existing tag destination instead of
> HEAD).

Do you mean you'd expect "--amend" to do that, which is different
from what "-f" does, so they should not be conflated into one?

If so, I think that makes sense and changing the behaviour of "-f"
is too confusing.


  reply	other threads:[~2019-04-12  2:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03 14:38 Feature request: Add --no-edit to git tag command Robert Dailey
2019-04-04  1:57 ` Jeff King
2019-04-04  3:26   ` Taylor Blau
2019-04-04 12:06     ` Jeff King
2019-04-04 13:56       ` Robert Dailey
2019-04-04 13:57         ` Robert Dailey
2019-04-05 22:21         ` Jeff King
2019-04-11 18:20           ` Bárbara de Castro Fernandes
2019-04-11 18:29             ` Jeff King
2019-04-12  2:32               ` Junio C Hamano [this message]
2019-04-12  2:33                 ` Jeff King
2019-04-04  9:13   ` Junio C Hamano
2019-04-04 12:01     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr2a8ymva.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=barbara.fernandes@usp.br \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    --cc=rcdailey.lists@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).