From: Junio C Hamano <gitster@pobox.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Git Mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] doc/rebase: extend examples to show continuing branches
Date: Tue, 05 Mar 2019 23:03:43 +0900 [thread overview]
Message-ID: <xmqqr2blto3k.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <alpine.LFD.2.21.1903050545460.24324@localhost.localdomain> (Robert P. J. Day's message of "Tue, 5 Mar 2019 05:48:28 -0500 (EST)")
"Robert P. J. Day" <rpjday@crashcourse.ca> writes:
> Currently, all of the examples for "man git-rebase" show rebasing from
> a branch that has had no further development, which might mislead
> readers into thinking that that is a necessary condition for rebasing,
> so tweak the examples to show further development on such a branch to
> clarify that.
We state the status-quo in present tense to start problem
description, so "Currently" is a noise word you can and should omit.
As I already said, at least one example that rebases a branch that
was forked from the midpoint of another branch, so the problem
description is already false. If we apply this patch, do we lose
all examples that rebase a branch that purely builds on top of the
tip of another branch? That would also mislead readers into
thinking that you need to advance the base branch before you can
rebase the forked branch ;-).
next prev parent reply other threads:[~2019-03-05 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 10:48 [PATCH] doc/rebase: extend examples to show continuing branches Robert P. J. Day
2019-03-05 14:03 ` Junio C Hamano [this message]
2019-03-05 14:04 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr2blto3k.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).