From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] fetch: fix compilation warning
Date: Sat, 29 Sep 2018 11:34:59 -0700 [thread overview]
Message-ID: <xmqqr2hc884s.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <4d868114-a7a5-a39b-d6d4-5a436419f105@ramsayjones.plus.com> (Ramsay Jones's message of "Thu, 27 Sep 2018 23:08:38 +0100")
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> You probably already know, but I had to add this on top of the 'pu'
> branch to get a clean compile tonight (your 'jc/war-on-string-list'
> branch).
It was not just about squelching a warning but simply broken code
that deserved to be warned/errored. I think what we have in 'pu'
now is already fixed.
Thanks.
> }
> hashmap_free(&remote_refs, 1);
> - string_list_clear(&remote_refs, 0);
> + string_list_clear(&remote_refs_list, 0);
> }
>
> static struct ref *get_ref_map(struct remote *remote,
prev parent reply other threads:[~2018-09-29 18:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 22:08 [PATCH] fetch: fix compilation warning Ramsay Jones
2018-09-29 18:34 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr2hc884s.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).