From: Junio C Hamano <gitster@pobox.com>
To: Jiang Xin <worldhello.net@gmail.com>
Cc: Jean-Noel Avila <jn.avila@free.fr>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH] i18n: fix mistakes in translated strings
Date: Tue, 04 Sep 2018 12:32:08 -0700 [thread overview]
Message-ID: <xmqqr2i983ev.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: CANYiYbHmU=j+MwLTumJ+BK_0msyPBeux92wF8VqL9J04VOc-FQ@mail.gmail.com
Jiang Xin <worldhello.net@gmail.com> writes:
> Jean-Noël Avila <jn.avila@free.fr> 于2018年8月24日周五 上午5:02写道:
>> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
>> index 2bcc70fdfe..b56028ba9d 100644
>> --- a/builtin/submodule--helper.c
>> +++ b/builtin/submodule--helper.c
>> @@ -542,7 +542,7 @@ static void runcommand_in_submodule_cb(const struct cache_entry *list_item,
>> argv_array_pushv(&cpr.args, info->argv);
>>
>> if (run_command(&cpr))
>> - die(_("run_command returned non-zero status while"
>> + die(_("run_command returned non-zero status while "
>> "recursing in the nested submodules of %s\n."),
>
> Any specific reason to put a period after newline?
> And there is another mistake just above this one:
>
> "run_command returned non-zero status for %s\n."
Embarrassing X-<
These are not something the "fix" introduces (rather it is what it
still misses), though.
prev parent reply other threads:[~2018-09-04 19:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 21:00 [PATCH] i18n: fix mistakes in translated strings Jean-Noël Avila
2018-08-23 21:28 ` Junio C Hamano
2018-09-03 17:52 ` Jean-Noël AVILA
2018-09-04 1:01 ` [L10N] Kickoff for Git 2.19.0 round 2 Jiang Xin
2018-09-04 1:52 ` [PATCH] i18n: fix mistakes in translated strings Jiang Xin
2018-09-04 14:18 ` [PATCH] i18n: fix dangling dot in die() messages Jean-Noel Avila
2018-09-04 15:05 ` Ævar Arnfjörð Bjarmason
2018-09-04 15:13 ` Jean-Noël Avila
2018-09-04 19:47 ` Junio C Hamano
2018-09-04 15:16 ` Duy Nguyen
2018-09-04 19:32 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr2i983ev.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jn.avila@free.fr \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).