From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 90DEA1F859 for ; Tue, 9 Aug 2016 19:37:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932347AbcHIThC (ORCPT ); Tue, 9 Aug 2016 15:37:02 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:56503 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932305AbcHIThB (ORCPT ); Tue, 9 Aug 2016 15:37:01 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 7B2B93452E; Tue, 9 Aug 2016 15:37:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=mQKnkK3JKQkNhfYwd8beoPWTcTM=; b=V09QY8 ePBvEOIw8gLHxEPxexZgjlF3i+Iwgo9TGROiGeWbQlFKjMS76wq8iwv5O9aO1tHF ljNvMuLmVgDTXa1BhR4i/V4llecHr5TPTGu50XTfM/OqIlhC/CC3T0ucYup9DK0F 5OSr2iXc70y7WFXLiY1i4n4kLxx/xBxjPkUUA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=f2YHtG9A2SYjcl9gRkJvA6vhHR7x4V6F l1t6Vkwb0NZgOcg20w1k9+nOJpkquFSVdgcDBsk74VzkOvJY4/4apFsvfkWeRime sd9/HQ5UBov+77WcwVeznMyqQU57p3xYIOLIii9DtQ24uBlUjtM5igokussCooCc KQuRGY9wB0E= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 729723452D; Tue, 9 Aug 2016 15:37:00 -0400 (EDT) Received: from pobox.com (unknown [104.132.0.95]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id CADFA3452C; Tue, 9 Aug 2016 15:36:59 -0400 (EDT) From: Junio C Hamano To: Vasco Almeida Cc: git@vger.kernel.org, =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Subject: Re: [PATCH 3/3] i18n: git-stash: mark message for translation References: <1470654961-2842-1-git-send-email-vascomalmeida@sapo.pt> <1470654961-2842-3-git-send-email-vascomalmeida@sapo.pt> Date: Tue, 09 Aug 2016 12:36:57 -0700 In-Reply-To: <1470654961-2842-3-git-send-email-vascomalmeida@sapo.pt> (Vasco Almeida's message of "Mon, 8 Aug 2016 11:16:01 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: A3C29906-5E68-11E6-89F5-EE617A1B28F4-77302942!pb-smtp2.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Vasco Almeida writes: > Signed-off-by: Vasco Almeida > --- > git-stash.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/git-stash.sh b/git-stash.sh > index 22fb8bc..9cbd682 100755 > --- a/git-stash.sh > +++ b/git-stash.sh > @@ -265,7 +265,7 @@ save_stash () { > create_stash "$stash_msg" $untracked > store_stash -m "$stash_msg" -q $w_commit || > die "$(gettext "Cannot save the current status")" > - say Saved working directory and index state "$stash_msg" > + say "$(eval_gettext "Saved working directory and index state \$stash_msg")" > > if test -z "$patch_mode" > then There is another "say" without gettext in pop_stash function. Don't you want to do that one, too?