Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Keith McGuigan <kmcguigan@twopensource.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 1/1] Don't free remote->name after fetch
Date: Tue, 14 Jun 2016 11:57:07 -0700	[thread overview]
Message-ID: <xmqqr3bz8upo.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CALnYDJObFtrKFBRbbaA2KV257j8L8gcKcGk-Pkhsyvbk7+oTjQ@mail.gmail.com> (Keith McGuigan's message of "Tue, 14 Jun 2016 14:54:38 -0400")

Keith McGuigan <kmcguigan@twopensource.com> writes:

> Yeah that was the only place I found where it was doing the strdup
> already (and in that situation, it has to).  All the other places just
> grabbed remote->name.
>
> Yes, sorry, I can sign off on this.  Do you want me to resend with the
> header in place, or is this confirmation good enough?

The latter ;-)  Thanks.

      reply	other threads:[~2016-06-14 18:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-14 18:28 [PATCH v2 1/1] Don't free remote->name after fetch kmcguigan
2016-06-14 18:49 ` Junio C Hamano
2016-06-14 18:54   ` Keith McGuigan
2016-06-14 18:57     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr3bz8upo.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=kmcguigan@twopensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox