From: Junio C Hamano <gitster@pobox.com>
To: Doug Kelly <dougk.ff7@gmail.com>
Cc: git@vger.kernel.org, peff@peff.net, sbeller@google.com
Subject: Re: [PATCH 2/4] t5304: Add test for .bitmap garbage files
Date: Wed, 13 Jan 2016 12:42:28 -0800 [thread overview]
Message-ID: <xmqqr3hlmcsr.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <543776a2a3e5d9f920280d06363a85f30a279d94.1452704305.git.dougk.ff7@gmail.com> (Doug Kelly's message of "Wed, 13 Jan 2016 11:07:10 -0600")
Doug Kelly <dougk.ff7@gmail.com> writes:
> When checking for pack garbage, .bitmap files are now detected as
> garbage when not associated with another .pack/.idx file.
Probably the above would read better with s/are now/should now be/,
as the _expect_failure this step introduces will be corrected with
Patch 4/4.
Also I'd suggest s/another/any/.
next prev parent reply other threads:[~2016-01-13 20:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 0:10 [PATCH 0/3] Add cleanup for garbage .bitmap files Doug Kelly
2015-11-14 0:10 ` [PATCH 1/3] prepare_packed_git(): find more garbage Doug Kelly
2015-11-14 0:43 ` Stefan Beller
2015-11-14 0:46 ` Doug Kelly
2015-11-14 0:46 ` [PATCH 2/3] t5304: Add test for .bitmap garbage files Doug Kelly
2015-11-14 0:46 ` [PATCH 3/3] gc: Clean garbage .bitmap files from pack dir Doug Kelly
2015-12-15 23:23 ` Jeff King
2015-11-25 18:43 ` [PATCH 1/3] prepare_packed_git(): find more garbage Stefan Beller
2015-11-26 6:15 ` Doug Kelly
2015-12-15 23:09 ` Jeff King
2015-12-15 23:25 ` Jeff King
2015-12-19 0:06 ` [PATCH v3 0/3] " Doug Kelly
2015-12-19 0:06 ` [PATCH 1/3] " Doug Kelly
2015-12-19 0:06 ` [PATCH 2/3] t5304: Add test for .bitmap garbage files Doug Kelly
2015-12-19 0:06 ` [PATCH 3/3] gc: Clean garbage .bitmap files from pack dir Doug Kelly
2015-12-19 2:01 ` Jeff King
2015-12-19 2:02 ` [PATCH v3 0/3] prepare_packed_git(): find more garbage Jeff King
2015-12-19 2:03 ` Jeff King
2016-01-11 16:35 ` Stefan Beller
2016-01-13 17:07 ` [PATCH v4 0/4] gc: Clean garbage .bitmap files from pack dir Doug Kelly
2016-01-13 17:07 ` [PATCH 1/4] prepare_packed_git(): find more garbage Doug Kelly
2016-01-13 17:07 ` [PATCH 2/4] t5304: Add test for .bitmap garbage files Doug Kelly
2016-01-13 20:42 ` Junio C Hamano [this message]
2016-01-13 17:07 ` [PATCH 3/4] t5304: Ensure wanted files are not deleted Doug Kelly
2016-01-13 20:55 ` Junio C Hamano
2016-01-18 16:54 ` Doug Kelly
2016-01-19 18:36 ` Junio C Hamano
2016-01-13 17:07 ` [PATCH 4/4] gc: Clean garbage .bitmap files from pack dir Doug Kelly
2015-11-26 6:18 ` [PATCH 1/3] prepare_packed_git(): find more garbage Doug Kelly
2015-11-14 0:47 ` Doug Kelly
2015-11-14 0:10 ` [PATCH 2/3] t5304: Add test for .bitmap garbage files Doug Kelly
2015-11-14 0:47 ` Stefan Beller
2015-11-14 0:10 ` [PATCH 3/3] gc: Clean garbage .bitmap files from pack dir Doug Kelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr3hlmcsr.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=dougk.ff7@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).