Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Sidhant Sharma <tigerkid001@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] worktree: usage: denote <branch> as optional with 'add'
Date: Sun, 18 Oct 2015 23:35:54 -0700	[thread overview]
Message-ID: <xmqqr3kr9xh1.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1445229893-4179-1-git-send-email-tigerkid001@gmail.com> (Sidhant Sharma's message of "Mon, 19 Oct 2015 10:14:53 +0530")

Sidhant Sharma <tigerkid001@gmail.com> writes:

> Although 1eb07d8 (worktree: add: auto-vivify new branch when
> <branch> is omitted, 2015-07-06) updated the documentation when
> <branch> became optional, it neglected to update the in-code
> usage message. Fix this oversight.
>
> Reported-by: ch3cooli@gmail.com
> Signed-off-by: Sidhant Sharma <tigerkid001@gmail.com>
> ---

Thanks.

I'll add "Helped-by: Eric Sunshine <sunshine@sunshineco.com>" and
queue.

>  builtin/worktree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/worktree.c b/builtin/worktree.c
> index 71bb770..33d2d37 100644
> --- a/builtin/worktree.c
> +++ b/builtin/worktree.c
> @@ -10,7 +10,7 @@
>  #include "refs.h"
>
>  static const char * const worktree_usage[] = {
> -	N_("git worktree add [<options>] <path> <branch>"),
> +	N_("git worktree add [<options>] <path> [<branch>]"),
>  	N_("git worktree prune [<options>]"),
>  	NULL
>  };
> --
> 2.6.2

      reply	other threads:[~2015-10-19  6:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-18 11:02 [PATCH] Fix worktree usage message Sidhant Sharma
2015-10-18 11:39 ` Kevin Daudt
2015-10-18 12:15   ` Sidhant Sharma
2015-10-18 16:51     ` Eric Sunshine
2015-10-19  4:44       ` [PATCH] worktree: usage: denote <branch> as optional with 'add' Sidhant Sharma
2015-10-19  6:35         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr3kr9xh1.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=tigerkid001@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox