Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: git@vger.kernel.org, 重田一聖 <kazumasa.shigeta@kanamei.com>
Subject: Re: [PATCH v4 0/7] stash creation: avoid unecessary index loads and refreshes
Date: Thu, 05 Nov 2026 13:52:49 -0800	[thread overview]
Message-ID: <xmqqse1fq72m.fsf@gitster.g> (raw)
In-Reply-To: <cover.1792767794.git.phillip.wood@dunelm.org.uk> (Phillip Wood's message of "Fri, 23 Oct 2026 16:03:28 +0100")

Phillip Wood <phillip.wood123@gmail.com> writes:

> Changes since V3:
>  - Avoid implict cast of enum create_result to int in create_stash()
>  - Fixed enum initializers
>  - Use switch() rather than if() when checking enum create_result
>    return values

These changes look very good.

> 5:  de5e0c196a9 = 5:  b62d3d080a8 stash create: rework temporary index creation
> 6:  61e4ce22a0f = 6:  8c54c118307 stash create: remove unnecessary index load and refresh
> 7:  a486a625c95 = 7:  f61ebbf9a3e stash: simplify reset_tree() function signature

I'll have another look at latter half of the series which I didn't
comment on in my earlier review separately.

Thanks.

      parent reply	other threads:[~2026-11-05 21:52 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 16:35 [PATCH 0/2] stash: stop checking for changes twice Phillip Wood
2026-10-05 16:35 ` [PATCH 1/2] stash create: remove duplicate changes detection Phillip Wood
2026-10-06 12:44   ` Junio C Hamano
2026-10-07 13:49     ` Phillip Wood
2026-10-05 16:35 ` [PATCH 2/2] stash push: " Phillip Wood
2026-10-06 14:27   ` Junio C Hamano
2026-10-07 13:46     ` Phillip Wood
2026-10-07 17:15       ` Junio C Hamano
2026-10-08 13:35         ` Phillip Wood
2026-10-14 15:40 ` [PATCH v2 0/7] stash creation: avoid unecessary index loads and refreshes Phillip Wood
2026-10-14 15:40   ` [PATCH v2 1/7] stash: use an enum for create status Phillip Wood
2026-10-14 15:40   ` [PATCH v2 2/7] stash create: remove duplicate changes detection Phillip Wood
2026-10-14 15:40   ` [PATCH v2 3/7] stash push: " Phillip Wood
2026-10-14 15:40   ` [PATCH v2 4/7] stash push: avoid duplicate calls to preload_index() Phillip Wood
2026-10-14 18:09     ` Junio C Hamano
2026-10-14 15:40   ` [PATCH v2 5/7] stash create: rework temporary index creation Phillip Wood
2026-10-14 18:16     ` Junio C Hamano
2026-10-20 14:54       ` Phillip Wood
2026-10-14 15:40   ` [PATCH v2 6/7] stash create: remove unnecessary index load and refresh Phillip Wood
2026-10-14 18:21     ` Junio C Hamano
2026-10-14 15:40   ` [PATCH v2 7/7] stash: simplify reset_tree() function signature Phillip Wood
2026-10-20 15:20 ` [PATCH v3 0/7] stash creation: avoid unecessary index loads and refreshes Phillip Wood
2026-10-20 15:20   ` [PATCH v3 1/7] stash: use an enum for create status Phillip Wood
2026-10-21  6:07     ` Junio C Hamano
2026-10-22 15:57       ` Phillip Wood
2026-10-22 17:01         ` Junio C Hamano
2026-10-22 18:33           ` Phillip Wood
2026-10-20 15:20   ` [PATCH v3 2/7] stash create: remove duplicate changes detection Phillip Wood
2026-10-20 15:20   ` [PATCH v3 3/7] stash push: " Phillip Wood
2026-10-20 15:20   ` [PATCH v3 4/7] stash push: avoid duplicate calls to preload_index() Phillip Wood
2026-10-20 15:20   ` [PATCH v3 5/7] stash create: rework temporary index creation Phillip Wood
2026-10-20 22:07     ` Junio C Hamano
2026-10-20 15:20   ` [PATCH v3 6/7] stash create: remove unnecessary index load and refresh Phillip Wood
2026-10-20 15:20   ` [PATCH v3 7/7] stash: simplify reset_tree() function signature Phillip Wood
2026-10-21  0:07   ` [PATCH v3 0/7] stash creation: avoid unecessary index loads and refreshes Junio C Hamano
2026-10-23 15:03 ` [PATCH v4 " Phillip Wood
2026-10-23 15:03   ` [PATCH v4 1/7] stash: use an enum for create status Phillip Wood
2026-10-23 15:03   ` [PATCH v4 2/7] stash create: remove duplicate changes detection Phillip Wood
2026-10-23 15:03   ` [PATCH v4 3/7] stash push: " Phillip Wood
2026-10-23 15:03   ` [PATCH v4 4/7] stash push: avoid duplicate calls to preload_index() Phillip Wood
2026-10-23 15:03   ` [PATCH v4 5/7] stash create: rework temporary index creation Phillip Wood
2026-11-05 21:55     ` Junio C Hamano
2026-10-23 15:03   ` [PATCH v4 6/7] stash create: remove unnecessary index load and refresh Phillip Wood
2026-10-23 15:03   ` [PATCH v4 7/7] stash: simplify reset_tree() function signature Phillip Wood
2026-11-05 21:52   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqse1fq72m.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=kazumasa.shigeta@kanamei.com \
    --cc=phillip.wood123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox