Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Yoichi Nakayama <yoichi.nakayama@gmail.com>
Cc: Yoichi NAKAYAMA via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH v3] worktree repair: detect relative path in .git file correctly
Date: Thu, 27 Aug 2026 10:00:36 -0700	[thread overview]
Message-ID: <xmqqse3za47f.fsf@gitster.g> (raw)
In-Reply-To: <CAF5D8-vocLWba-rvKxy3WWB1ZHTh1+eRcRWiMqv0M-CX56Y71A@mail.gmail.com> (Yoichi Nakayama's message of "Thu, 27 Aug 2026 23:38:15 +0900")

Yoichi Nakayama <yoichi.nakayama@gmail.com> writes:

> Are you concerned about the lack of explanation in the commit
> message, or about the functional differences between
> `read_gitfile_raw()` and `read_gitfile_gently()`?

Mostly the former, i.e., the commit message too sketchy.

I now understand that these two functions need to be more different
than just the _raw() not calling strbuf_realpath() and the other
calling strbuf_realpath().  The functional split is fine.

Thanks.


  reply	other threads:[~2026-08-27 17:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-15 13:11 [PATCH] worktree repair: detect relative path in .git file correctly Yoichi NAKAYAMA via GitGitGadget
2026-08-17 17:21 ` Junio C Hamano
2026-08-17 21:27   ` Yoichi Nakayama
2026-08-20 15:46 ` [PATCH v2] " Yoichi NAKAYAMA via GitGitGadget
2026-08-21  2:09   ` Junio C Hamano
2026-08-21 20:36 ` [PATCH v3] " Yoichi NAKAYAMA via GitGitGadget
2026-08-21 22:02   ` Junio C Hamano
2026-08-21 22:20     ` Junio C Hamano
2026-08-27 14:38       ` Yoichi Nakayama
2026-08-27 17:00         ` Junio C Hamano [this message]
2026-08-28 15:19 ` [PATCH v4] " Yoichi NAKAYAMA via GitGitGadget
2026-08-28 17:41   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqse3za47f.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=yoichi.nakayama@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox